Skip to content

Commit f38f284

Browse files
committed
io_uring: only initialize io_kiocb rsrc_nodes when needed
Add the empty node initializing to the preinit part of the io_kiocb allocation, and reset them if they have been used. Signed-off-by: Jens Axboe <[email protected]>
1 parent 0701db7 commit f38f284

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

io_uring/io_uring.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -947,6 +947,8 @@ void io_req_defer_failed(struct io_kiocb *req, s32 res)
947947
static void io_preinit_req(struct io_kiocb *req, struct io_ring_ctx *ctx)
948948
{
949949
req->ctx = ctx;
950+
req->rsrc_nodes[IORING_RSRC_FILE] = rsrc_empty_node;
951+
req->rsrc_nodes[IORING_RSRC_BUFFER] = rsrc_empty_node;
950952
req->link = NULL;
951953
req->async_data = NULL;
952954
/* not necessary, but safer to zero */
@@ -2032,8 +2034,6 @@ static int io_init_req(struct io_ring_ctx *ctx, struct io_kiocb *req,
20322034
req->flags = (__force io_req_flags_t) sqe_flags;
20332035
req->cqe.user_data = READ_ONCE(sqe->user_data);
20342036
req->file = NULL;
2035-
req->rsrc_nodes[IORING_RSRC_FILE] = rsrc_empty_node;
2036-
req->rsrc_nodes[IORING_RSRC_BUFFER] = rsrc_empty_node;
20372037
req->task = current;
20382038
req->cancel_seq_set = false;
20392039

io_uring/rsrc.h

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,14 @@ static inline void io_put_rsrc_node(struct io_rsrc_node *node)
8181

8282
static inline void io_req_put_rsrc_nodes(struct io_kiocb *req)
8383
{
84-
io_put_rsrc_node(req->rsrc_nodes[IORING_RSRC_FILE]);
85-
io_put_rsrc_node(req->rsrc_nodes[IORING_RSRC_BUFFER]);
84+
if (req->rsrc_nodes[IORING_RSRC_FILE] != rsrc_empty_node) {
85+
io_put_rsrc_node(req->rsrc_nodes[IORING_RSRC_FILE]);
86+
req->rsrc_nodes[IORING_RSRC_FILE] = rsrc_empty_node;
87+
}
88+
if (req->rsrc_nodes[IORING_RSRC_BUFFER] != rsrc_empty_node) {
89+
io_put_rsrc_node(req->rsrc_nodes[IORING_RSRC_BUFFER]);
90+
req->rsrc_nodes[IORING_RSRC_BUFFER] = rsrc_empty_node;
91+
}
8692
}
8793

8894
static inline void io_req_assign_rsrc_node(struct io_kiocb *req,

0 commit comments

Comments
 (0)