ethernet: myri10ge: Fix missing error code in myri10ge_probe()

Jiapeng Chong · davem330 · commit f336d0b93ae9 · 2021-06-01T15:54:38.000-07:00
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'status'.

Eliminate the follow smatch warning:

drivers/net/ethernet/myricom/myri10ge/myri10ge.c:3818 myri10ge_probe()
warn: missing error code 'status'.

Reported-by: Abaci Robot &lt;abaci@linux.alibaba.com&gt;
Signed-off-by: Jiapeng Chong &lt;jiapeng.chong@linux.alibaba.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -3815,6 +3815,7 @@ static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		dev_err(&pdev->dev,
 			"invalid sram_size %dB or board span %ldB\n",
 			mgp->sram_size, mgp->board_span);
+		status = -EINVAL;
 		goto abort_with_ioremap;
 	}
 	memcpy_fromio(mgp->eeprom_strings,

Original file line number	Diff line number	Diff line change
`@@ -3815,6 +3815,7 @@ static int myri10ge_probe(struct pci_dev pdev, const struct pci_device_id ent)`
`3815`	`3815`	`dev_err(&pdev->dev,`
`3816`	`3816`	`"invalid sram_size %dB or board span %ldB\n",`
`3817`	`3817`	`mgp->sram_size, mgp->board_span);`
	`3818`	`+ status = -EINVAL;`
`3818`	`3819`	`goto abort_with_ioremap;`
`3819`	`3820`	`}`
`3820`	`3821`	`memcpy_fromio(mgp->eeprom_strings,`