Skip to content

Commit e25d5db

Browse files
winter4lingdavem330
authored andcommitted
veth: ignore peer tx_dropped when counting local rx_dropped
When local NET_RX backlog is full due to traffic overrun, peer veth tx_dropped counter increases. At that time, list local veth stats, rx_dropped has double value of peer tx_dropped, even bigger than transmit packets by peer. In NET_RX softirq process, if any packet drop case happens, it increases dev's rx_dropped counter and returns NET_RX_DROP. At veth tx side, it records any error returned from peer netif_rx into local dev tx_dropped counter. In veth get stats process, it puts local dev rx_dropped and peer dev tx_dropped into together as local rx_drpped value. So that it shows double value of real dropped packets number in this case. This patch ignores peer tx_dropped when counting local rx_dropped, since peer tx_dropped is duplicated to local rx_dropped at most cases. Signed-off-by: Jiang Lidong <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 2f63f2d commit e25d5db

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/veth.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ static void veth_get_stats64(struct net_device *dev,
328328
rcu_read_lock();
329329
peer = rcu_dereference(priv->peer);
330330
if (peer) {
331-
tot->rx_dropped += veth_stats_tx(peer, &packets, &bytes);
331+
veth_stats_tx(peer, &packets, &bytes);
332332
tot->rx_bytes += bytes;
333333
tot->rx_packets += packets;
334334

0 commit comments

Comments
 (0)