cpufreq: amd-pstate: Remove unnecessary driver_lock in set_boost

dhananjay-AMD · vireshk · commit db1cafc77aaa · 2025-02-06T09:04:30.000+05:30
set_boost is a per-policy function call, hence a driver wide lock is
unnecessary. Also this mutex_acquire can collide with the mutex_acquire
from the mode-switch path in status_store(), which can lead to a
deadlock. So, remove it.

Signed-off-by: Dhananjay Ugwekar &lt;dhananjay.ugwekar@amd.com&gt;
Acked-by: Mario Limonciello &lt;mario.limonciello@amd.com&gt;
Signed-off-by: Viresh Kumar &lt;viresh.kumar@linaro.org&gt;
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
@@ -744,7 +744,6 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
 		pr_err("Boost mode is not supported by this processor or SBIOS\n");
 		return -EOPNOTSUPP;
 	}
-	guard(mutex)(&amd_pstate_driver_lock);
 
 	ret = amd_pstate_cpu_boost_update(policy, state);
 	policy->boost_enabled = !ret ? state : false;

Original file line number	Diff line number	Diff line change
`@@ -744,7 +744,6 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)`
`744`	`744`	`pr_err("Boost mode is not supported by this processor or SBIOS\n");`
`745`	`745`	`return -EOPNOTSUPP;`
`746`	`746`	`}`
`747`		`- guard(mutex)(&amd_pstate_driver_lock);`
`748`	`747`
`749`	`748`	`ret = amd_pstate_cpu_boost_update(policy, state);`
`750`	`749`	`policy->boost_enabled = !ret ? state : false;`