macvlan: broadcast addr should be part of mc_filter

edumazet · davem330 · commit d52704304074 · 2013-02-08T17:55:48.000-05:00
commit cd431e7 (macvlan: add multicast filter) forgot the broadcast case. Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: Maciej Żenczykowski <maze@google.com> SIgned-off-by: Maciej Żenczykowski <maze@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
@@ -426,6 +426,9 @@ static void macvlan_set_mac_lists(struct net_device *dev)
 		netdev_for_each_mc_addr(ha, dev) {
 			__set_bit(mc_hash(ha->addr), filter);
 		}
+
+		__set_bit(mc_hash(dev->broadcast), filter);
+
 		bitmap_copy(vlan->mc_filter, filter, MACVLAN_MC_FILTER_SZ);
 	}
 	dev_uc_sync(vlan->lowerdev, dev);

Original file line number	Diff line number	Diff line change
`@@ -426,6 +426,9 @@ static void macvlan_set_mac_lists(struct net_device *dev)`
`426`	`426`	`netdev_for_each_mc_addr(ha, dev) {`
`427`	`427`	`__set_bit(mc_hash(ha->addr), filter);`
`428`	`428`	`}`
	`429`	`+`
	`430`	`+ __set_bit(mc_hash(dev->broadcast), filter);`
	`431`	`+`
`429`	`432`	`bitmap_copy(vlan->mc_filter, filter, MACVLAN_MC_FILTER_SZ);`
`430`	`433`	`}`
`431`	`434`	`dev_uc_sync(vlan->lowerdev, dev);`