Skip to content

Commit d2d9c9b

Browse files
Vinith Kumar Rjeff-t-johnson
authored andcommitted
wifi: ath12k: Report proper tx completion status to mac80211
Currently Tx completion for few exception packets are received from firmware and the tx status updated to mac80211. The tx status values of HAL_WBM_REL_HTT_TX_COMP_STATUS_DROP and HAL_WBM_REL_HTT_TX_COMP_STATUS_TTL are considered as tx failure and reported as tx failure to mac80211. But these failure status is due to internal firmware tx drop and these packets were not tried to transmit in the air. In case of mesh this invalid tx status report might trigger mpath broken issue due to increase in mpath fail average. So do not report these tx status as tx failure instead free the skb by calling ieee80211_free_txskb(), and that will be accounted as dropped frame. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 Signed-off-by: Vinith Kumar R <[email protected]> Signed-off-by: Tamizh Chelvam Raja <[email protected]> Acked-by: Jeff Johnson <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jeff Johnson <[email protected]>
1 parent 1bd9ffe commit d2d9c9b

File tree

1 file changed

+2
-2
lines changed
  • drivers/net/wireless/ath/ath12k

1 file changed

+2
-2
lines changed

drivers/net/wireless/ath/ath12k/dp_tx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -576,13 +576,13 @@ ath12k_dp_tx_process_htt_tx_complete(struct ath12k_base *ab,
576576

577577
switch (wbm_status) {
578578
case HAL_WBM_REL_HTT_TX_COMP_STATUS_OK:
579-
case HAL_WBM_REL_HTT_TX_COMP_STATUS_DROP:
580-
case HAL_WBM_REL_HTT_TX_COMP_STATUS_TTL:
581579
ts.acked = (wbm_status == HAL_WBM_REL_HTT_TX_COMP_STATUS_OK);
582580
ts.ack_rssi = le32_get_bits(status_desc->info2,
583581
HTT_TX_WBM_COMP_INFO2_ACK_RSSI);
584582
ath12k_dp_tx_htt_tx_complete_buf(ab, msdu, tx_ring, &ts);
585583
break;
584+
case HAL_WBM_REL_HTT_TX_COMP_STATUS_DROP:
585+
case HAL_WBM_REL_HTT_TX_COMP_STATUS_TTL:
586586
case HAL_WBM_REL_HTT_TX_COMP_STATUS_REINJ:
587587
case HAL_WBM_REL_HTT_TX_COMP_STATUS_INSPECT:
588588
ath12k_dp_tx_free_txbuf(ab, msdu, mac_id, tx_ring);

0 commit comments

Comments
 (0)