Skip to content

Commit c6ccc4d

Browse files
Hans de GoedeBartosz Golaszewski
authored andcommitted
gpiolib: Extend software-node support to support secondary software-nodes
When a software-node gets added to a device which already has another fwnode as primary node it will become the secondary fwnode for that device. Currently if a software-node with GPIO properties ends up as the secondary fwnode then gpiod_find_by_fwnode() will fail to find the GPIOs. Add a new gpiod_fwnode_lookup() helper which falls back to calling gpiod_find_by_fwnode() with the secondary fwnode if the GPIO was not found in the primary fwnode. Fixes: e7f9ff5 ("gpiolib: add support for software nodes") Cc: [email protected] Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Dmitry Torokhov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bartosz Golaszewski <[email protected]>
1 parent 07e27ad commit c6ccc4d

File tree

1 file changed

+19
-2
lines changed

1 file changed

+19
-2
lines changed

drivers/gpio/gpiolib.c

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4604,6 +4604,23 @@ static struct gpio_desc *gpiod_find_by_fwnode(struct fwnode_handle *fwnode,
46044604
return desc;
46054605
}
46064606

4607+
static struct gpio_desc *gpiod_fwnode_lookup(struct fwnode_handle *fwnode,
4608+
struct device *consumer,
4609+
const char *con_id,
4610+
unsigned int idx,
4611+
enum gpiod_flags *flags,
4612+
unsigned long *lookupflags)
4613+
{
4614+
struct gpio_desc *desc;
4615+
4616+
desc = gpiod_find_by_fwnode(fwnode, consumer, con_id, idx, flags, lookupflags);
4617+
if (gpiod_not_found(desc) && !IS_ERR_OR_NULL(fwnode))
4618+
desc = gpiod_find_by_fwnode(fwnode->secondary, consumer, con_id,
4619+
idx, flags, lookupflags);
4620+
4621+
return desc;
4622+
}
4623+
46074624
struct gpio_desc *gpiod_find_and_request(struct device *consumer,
46084625
struct fwnode_handle *fwnode,
46094626
const char *con_id,
@@ -4622,8 +4639,8 @@ struct gpio_desc *gpiod_find_and_request(struct device *consumer,
46224639
int ret = 0;
46234640

46244641
scoped_guard(srcu, &gpio_devices_srcu) {
4625-
desc = gpiod_find_by_fwnode(fwnode, consumer, con_id, idx,
4626-
&flags, &lookupflags);
4642+
desc = gpiod_fwnode_lookup(fwnode, consumer, con_id, idx,
4643+
&flags, &lookupflags);
46274644
if (gpiod_not_found(desc) && platform_lookup_allowed) {
46284645
/*
46294646
* Either we are not using DT or ACPI, or their lookup

0 commit comments

Comments
 (0)