Skip to content

Commit c46ee8a

Browse files
Christoph Hellwigdchinner
authored andcommitted
xfs: factor btree block freeing into a helper
Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Brian Foster <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
1 parent 196328e commit c46ee8a

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

fs/xfs/libxfs/xfs_btree.c

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,19 @@ xfs_btree_sblock_verify_crc(
294294
return true;
295295
}
296296

297+
static int
298+
xfs_btree_free_block(
299+
struct xfs_btree_cur *cur,
300+
struct xfs_buf *bp)
301+
{
302+
int error;
303+
304+
error = cur->bc_ops->free_block(cur, bp);
305+
if (!error)
306+
XFS_BTREE_STATS_INC(cur, free);
307+
return error;
308+
}
309+
297310
/*
298311
* Delete the btree cursor.
299312
*/
@@ -3282,12 +3295,11 @@ xfs_btree_kill_iroot(
32823295
#endif
32833296
xfs_btree_copy_ptrs(cur, pp, cpp, numrecs);
32843297

3285-
error = cur->bc_ops->free_block(cur, cbp);
3298+
error = xfs_btree_free_block(cur, cbp);
32863299
if (error) {
32873300
XFS_BTREE_TRACE_CURSOR(cur, XBT_ERROR);
32883301
return error;
32893302
}
3290-
XFS_BTREE_STATS_INC(cur, free);
32913303

32923304
cur->bc_bufs[level - 1] = NULL;
32933305
be16_add_cpu(&block->bb_level, -1);
@@ -3320,14 +3332,12 @@ xfs_btree_kill_root(
33203332
*/
33213333
cur->bc_ops->set_root(cur, newroot, -1);
33223334

3323-
error = cur->bc_ops->free_block(cur, bp);
3335+
error = xfs_btree_free_block(cur, bp);
33243336
if (error) {
33253337
XFS_BTREE_TRACE_CURSOR(cur, XBT_ERROR);
33263338
return error;
33273339
}
33283340

3329-
XFS_BTREE_STATS_INC(cur, free);
3330-
33313341
cur->bc_bufs[level] = NULL;
33323342
cur->bc_ra[level] = 0;
33333343
cur->bc_nlevels--;
@@ -3833,10 +3843,9 @@ xfs_btree_delrec(
38333843
}
38343844

38353845
/* Free the deleted block. */
3836-
error = cur->bc_ops->free_block(cur, rbp);
3846+
error = xfs_btree_free_block(cur, rbp);
38373847
if (error)
38383848
goto error0;
3839-
XFS_BTREE_STATS_INC(cur, free);
38403849

38413850
/*
38423851
* If we joined with the left neighbor, set the buffer in the

0 commit comments

Comments
 (0)