Skip to content

Commit c468efe

Browse files
tomratbertdavem330
authored andcommitted
net: Remove superfluous setting of key_basic
key_basic is set twice in __skb_flow_dissect which seems unnecessary. Remove second one. Acked-by: Jiri Pirko <[email protected]> Signed-off-by: Tom Herbert <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 730fc43 commit c468efe

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

net/core/flow_dissector.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -343,12 +343,6 @@ bool __skb_flow_dissect(const struct sk_buff *skb,
343343
break;
344344
}
345345

346-
/* It is ensured by skb_flow_dissector_init() that basic key will
347-
* be always present.
348-
*/
349-
key_basic = skb_flow_dissector_target(flow_dissector,
350-
FLOW_DISSECTOR_KEY_BASIC,
351-
target_container);
352346
key_basic->n_proto = proto;
353347
key_basic->ip_proto = ip_proto;
354348
key_basic->thoff = (u16) nhoff;

0 commit comments

Comments
 (0)