Skip to content

Commit c36e344

Browse files
Tvrtko Ursulinrodrigovivi
authored andcommitted
drm/xe: Use correct type width for alignment in fb pinning code
Plane->min_alignment returns an unsigned int so lets use that in the whole relevant call chain. Signed-off-by: Tvrtko Ursulin <[email protected]> Reviewed-by: Rodrigo Vivi <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Rodrigo Vivi <[email protected]>
1 parent 52a237e commit c36e344

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

drivers/gpu/drm/xe/display/xe_fb_pin.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ write_dpt_remapped(struct xe_bo *bo, struct iosys_map *map, u32 *dpt_ofs,
8181
static int __xe_pin_fb_vma_dpt(const struct intel_framebuffer *fb,
8282
const struct i915_gtt_view *view,
8383
struct i915_vma *vma,
84-
u64 physical_alignment)
84+
unsigned int alignment)
8585
{
8686
struct xe_device *xe = to_xe_device(fb->base.dev);
8787
struct xe_tile *tile0 = xe_device_get_root_tile(xe);
@@ -107,23 +107,23 @@ static int __xe_pin_fb_vma_dpt(const struct intel_framebuffer *fb,
107107
XE_BO_FLAG_VRAM0 |
108108
XE_BO_FLAG_GGTT |
109109
XE_BO_FLAG_PAGETABLE,
110-
physical_alignment);
110+
alignment);
111111
else
112112
dpt = xe_bo_create_pin_map_at_aligned(xe, tile0, NULL,
113113
dpt_size, ~0ull,
114114
ttm_bo_type_kernel,
115115
XE_BO_FLAG_STOLEN |
116116
XE_BO_FLAG_GGTT |
117117
XE_BO_FLAG_PAGETABLE,
118-
physical_alignment);
118+
alignment);
119119
if (IS_ERR(dpt))
120120
dpt = xe_bo_create_pin_map_at_aligned(xe, tile0, NULL,
121121
dpt_size, ~0ull,
122122
ttm_bo_type_kernel,
123123
XE_BO_FLAG_SYSTEM |
124124
XE_BO_FLAG_GGTT |
125125
XE_BO_FLAG_PAGETABLE,
126-
physical_alignment);
126+
alignment);
127127
if (IS_ERR(dpt))
128128
return PTR_ERR(dpt);
129129

@@ -193,7 +193,7 @@ write_ggtt_rotated(struct xe_bo *bo, struct xe_ggtt *ggtt, u32 *ggtt_ofs, u32 bo
193193
static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb,
194194
const struct i915_gtt_view *view,
195195
struct i915_vma *vma,
196-
u64 physical_alignment)
196+
unsigned int alignment)
197197
{
198198
struct drm_gem_object *obj = intel_fb_bo(&fb->base);
199199
struct xe_bo *bo = gem_to_xe_bo(obj);
@@ -276,7 +276,7 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb,
276276

277277
static struct i915_vma *__xe_pin_fb_vma(const struct intel_framebuffer *fb,
278278
const struct i915_gtt_view *view,
279-
u64 physical_alignment)
279+
unsigned int alignment)
280280
{
281281
struct drm_device *dev = fb->base.dev;
282282
struct xe_device *xe = to_xe_device(dev);
@@ -326,9 +326,9 @@ static struct i915_vma *__xe_pin_fb_vma(const struct intel_framebuffer *fb,
326326

327327
vma->bo = bo;
328328
if (intel_fb_uses_dpt(&fb->base))
329-
ret = __xe_pin_fb_vma_dpt(fb, view, vma, physical_alignment);
329+
ret = __xe_pin_fb_vma_dpt(fb, view, vma, alignment);
330330
else
331-
ret = __xe_pin_fb_vma_ggtt(fb, view, vma, physical_alignment);
331+
ret = __xe_pin_fb_vma_ggtt(fb, view, vma, alignment);
332332
if (ret)
333333
goto err_unpin;
334334

@@ -421,15 +421,15 @@ int intel_plane_pin_fb(struct intel_plane_state *new_plane_state,
421421
struct i915_vma *vma;
422422
struct intel_framebuffer *intel_fb = to_intel_framebuffer(fb);
423423
struct intel_plane *plane = to_intel_plane(new_plane_state->uapi.plane);
424-
u64 phys_alignment = plane->min_alignment(plane, fb, 0);
424+
unsigned int alignment = plane->min_alignment(plane, fb, 0);
425425

426426
if (reuse_vma(new_plane_state, old_plane_state))
427427
return 0;
428428

429429
/* We reject creating !SCANOUT fb's, so this is weird.. */
430430
drm_WARN_ON(bo->ttm.base.dev, !(bo->flags & XE_BO_FLAG_SCANOUT));
431431

432-
vma = __xe_pin_fb_vma(intel_fb, &new_plane_state->view.gtt, phys_alignment);
432+
vma = __xe_pin_fb_vma(intel_fb, &new_plane_state->view.gtt, alignment);
433433

434434
if (IS_ERR(vma))
435435
return PTR_ERR(vma);

0 commit comments

Comments
 (0)