Skip to content

Commit c1c8380

Browse files
Dan CarpenterKalle Valo
authored andcommitted
b43legacy: fix a lower bounds test
The problem is that "channel" is an unsigned int, when it's less 5 the value of "channel - 5" is not a negative number as one would expect but is very high positive value instead. This means that "start" becomes a very high positive value. The result of that is that we never enter the "for (i = start; i <= end; i++) {" loop. Instead of storing the result from b43legacy_radio_aci_detect() it just uses zero. Fixes: 75388ac ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices") Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Michael Büsch <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/20211006073542.GD8404@kili
1 parent 0182d07 commit c1c8380

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/wireless/broadcom/b43legacy

1 file changed

+1
-1
lines changed

drivers/net/wireless/broadcom/b43legacy/radio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ u8 b43legacy_radio_aci_scan(struct b43legacy_wldev *dev)
283283
& 0x7FFF);
284284
b43legacy_set_all_gains(dev, 3, 8, 1);
285285

286-
start = (channel - 5 > 0) ? channel - 5 : 1;
286+
start = (channel > 5) ? channel - 5 : 1;
287287
end = (channel + 5 < 14) ? channel + 5 : 13;
288288

289289
for (i = start; i <= end; i++) {

0 commit comments

Comments
 (0)