Skip to content

Commit c069fcd

Browse files
Arkadi Sharshevskydavem330
authored andcommitted
net: dsa: Remove support for bypass bridge port attributes/vlan set
The bridge port attributes/vlan for DSA devices should be set only from bridge code. Furthermore, The vlans are synced totally with the bridge so there is no need for special dump support. Signed-off-by: Arkadi Sharshevsky <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent a0b6b8c commit c069fcd

File tree

4 files changed

+0
-26
lines changed

4 files changed

+0
-26
lines changed

include/net/dsa.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -378,10 +378,6 @@ struct dsa_switch_ops {
378378
struct switchdev_trans *trans);
379379
int (*port_vlan_del)(struct dsa_switch *ds, int port,
380380
const struct switchdev_obj_port_vlan *vlan);
381-
int (*port_vlan_dump)(struct dsa_switch *ds, int port,
382-
struct switchdev_obj_port_vlan *vlan,
383-
switchdev_obj_dump_cb_t *cb);
384-
385381
/*
386382
* Forwarding database
387383
*/

net/dsa/dsa_priv.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,6 @@ int dsa_port_vlan_add(struct dsa_port *dp,
147147
struct switchdev_trans *trans);
148148
int dsa_port_vlan_del(struct dsa_port *dp,
149149
const struct switchdev_obj_port_vlan *vlan);
150-
int dsa_port_vlan_dump(struct dsa_port *dp,
151-
struct switchdev_obj_port_vlan *vlan,
152-
switchdev_obj_dump_cb_t *cb);
153-
154150
/* slave.c */
155151
extern const struct dsa_device_ops notag_netdev_ops;
156152
void dsa_slave_mii_bus_init(struct dsa_switch *ds);

net/dsa/port.c

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -246,15 +246,3 @@ int dsa_port_vlan_del(struct dsa_port *dp,
246246

247247
return dsa_port_notify(dp, DSA_NOTIFIER_VLAN_DEL, &info);
248248
}
249-
250-
int dsa_port_vlan_dump(struct dsa_port *dp,
251-
struct switchdev_obj_port_vlan *vlan,
252-
switchdev_obj_dump_cb_t *cb)
253-
{
254-
struct dsa_switch *ds = dp->ds;
255-
256-
if (ds->ops->port_vlan_dump)
257-
return ds->ops->port_vlan_dump(ds, dp->index, vlan, cb);
258-
259-
return -EOPNOTSUPP;
260-
}

net/dsa/slave.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -302,9 +302,6 @@ static int dsa_slave_port_obj_dump(struct net_device *dev,
302302
case SWITCHDEV_OBJ_ID_PORT_MDB:
303303
err = dsa_port_mdb_dump(dp, SWITCHDEV_OBJ_PORT_MDB(obj), cb);
304304
break;
305-
case SWITCHDEV_OBJ_ID_PORT_VLAN:
306-
err = dsa_port_vlan_dump(dp, SWITCHDEV_OBJ_PORT_VLAN(obj), cb);
307-
break;
308305
default:
309306
err = -EOPNOTSUPP;
310307
break;
@@ -988,9 +985,6 @@ static const struct net_device_ops dsa_slave_netdev_ops = {
988985
.ndo_netpoll_cleanup = dsa_slave_netpoll_cleanup,
989986
.ndo_poll_controller = dsa_slave_poll_controller,
990987
#endif
991-
.ndo_bridge_getlink = switchdev_port_bridge_getlink,
992-
.ndo_bridge_setlink = switchdev_port_bridge_setlink,
993-
.ndo_bridge_dellink = switchdev_port_bridge_dellink,
994988
.ndo_get_phys_port_name = dsa_slave_get_phys_port_name,
995989
.ndo_setup_tc = dsa_slave_setup_tc,
996990
.ndo_get_stats64 = dsa_slave_get_stats64,

0 commit comments

Comments
 (0)