Skip to content

Commit be75d31

Browse files
minakuba-moo
authored andcommitted
selftests: pp-bench: remove page_pool_put_page wrapper
Minor cleanup: remove the pointless looking _ wrapper around page_pool_put_page, and just do the call directly. Signed-off-by: Mina Almasry <[email protected]> Reviewed-by: Simon Horman <[email protected]> Reviewed-by: Toke Høiland-Jørgensen <[email protected]> Reviewed-by: Ilias Apalodimas <[email protected]> Acked-by: Jesper Dangaard Brouer <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 8d3e098 commit be75d31

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,6 @@
1616
static int verbose = 1;
1717
#define MY_POOL_SIZE 1024
1818

19-
static void _page_pool_put_page(struct page_pool *pool, struct page *page,
20-
bool allow_direct)
21-
{
22-
page_pool_put_page(pool, page, -1, allow_direct);
23-
}
24-
2519
/* Makes tests selectable. Useful for perf-record to analyze a single test.
2620
* Hint: Bash shells support writing binary number like: $((2#101010)
2721
*
@@ -121,7 +115,7 @@ static void pp_fill_ptr_ring(struct page_pool *pp, int elems)
121115
for (i = 0; i < elems; i++)
122116
array[i] = page_pool_alloc_pages(pp, gfp_mask);
123117
for (i = 0; i < elems; i++)
124-
_page_pool_put_page(pp, array[i], false);
118+
page_pool_put_page(pp, array[i], -1, false);
125119

126120
kfree(array);
127121
}
@@ -180,14 +174,14 @@ static int time_bench_page_pool(struct time_bench_record *rec, void *data,
180174

181175
} else if (type == type_ptr_ring) {
182176
/* Normal return path */
183-
_page_pool_put_page(pp, page, false);
177+
page_pool_put_page(pp, page, -1, false);
184178

185179
} else if (type == type_page_allocator) {
186180
/* Test if not pages are recycled, but instead
187181
* returned back into systems page allocator
188182
*/
189183
get_page(page); /* cause no-recycling */
190-
_page_pool_put_page(pp, page, false);
184+
page_pool_put_page(pp, page, -1, false);
191185
put_page(page);
192186
} else {
193187
BUILD_BUG();

0 commit comments

Comments
 (0)