Skip to content

Commit be03a3a

Browse files
tlendackyherbertx
authored andcommitted
crypto: ccp - Convert calls to their devm_ counterparts
Where applicable, convert calls to their devm_ counterparts, e.g. kzalloc to devm_kzalloc. Signed-off-by: Tom Lendacky <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
1 parent 261bf07 commit be03a3a

File tree

3 files changed

+9
-23
lines changed

3 files changed

+9
-23
lines changed

drivers/crypto/ccp/ccp-dev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ struct ccp_device *ccp_alloc_struct(struct device *dev)
295295
{
296296
struct ccp_device *ccp;
297297

298-
ccp = kzalloc(sizeof(*ccp), GFP_KERNEL);
298+
ccp = devm_kzalloc(dev, sizeof(*ccp), GFP_KERNEL);
299299
if (!ccp)
300300
return NULL;
301301
ccp->dev = dev;

drivers/crypto/ccp/ccp-pci.c

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -174,19 +174,18 @@ static int ccp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
174174
if (!ccp)
175175
goto e_err;
176176

177-
ccp_pci = kzalloc(sizeof(*ccp_pci), GFP_KERNEL);
178-
if (!ccp_pci) {
179-
ret = -ENOMEM;
180-
goto e_free1;
181-
}
177+
ccp_pci = devm_kzalloc(dev, sizeof(*ccp_pci), GFP_KERNEL);
178+
if (!ccp_pci)
179+
goto e_err;
180+
182181
ccp->dev_specific = ccp_pci;
183182
ccp->get_irq = ccp_get_irqs;
184183
ccp->free_irq = ccp_free_irqs;
185184

186185
ret = pci_request_regions(pdev, "ccp");
187186
if (ret) {
188187
dev_err(dev, "pci_request_regions failed (%d)\n", ret);
189-
goto e_free2;
188+
goto e_err;
190189
}
191190

192191
ret = pci_enable_device(pdev);
@@ -239,12 +238,6 @@ static int ccp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
239238
e_regions:
240239
pci_release_regions(pdev);
241240

242-
e_free2:
243-
kfree(ccp_pci);
244-
245-
e_free1:
246-
kfree(ccp);
247-
248241
e_err:
249242
dev_notice(dev, "initialization failed\n");
250243
return ret;
@@ -266,8 +259,6 @@ static void ccp_pci_remove(struct pci_dev *pdev)
266259

267260
pci_release_regions(pdev);
268261

269-
kfree(ccp);
270-
271262
dev_notice(dev, "disabled\n");
272263
}
273264

drivers/crypto/ccp/ccp-platform.c

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ static int ccp_platform_probe(struct platform_device *pdev)
103103
ccp->io_map = devm_ioremap_resource(dev, ior);
104104
if (IS_ERR(ccp->io_map)) {
105105
ret = PTR_ERR(ccp->io_map);
106-
goto e_free;
106+
goto e_err;
107107
}
108108
ccp->io_regs = ccp->io_map;
109109

@@ -112,7 +112,7 @@ static int ccp_platform_probe(struct platform_device *pdev)
112112
ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(48));
113113
if (ret) {
114114
dev_err(dev, "dma_set_mask_and_coherent failed (%d)\n", ret);
115-
goto e_free;
115+
goto e_err;
116116
}
117117

118118
if (of_property_read_bool(dev->of_node, "dma-coherent"))
@@ -124,15 +124,12 @@ static int ccp_platform_probe(struct platform_device *pdev)
124124

125125
ret = ccp_init(ccp);
126126
if (ret)
127-
goto e_free;
127+
goto e_err;
128128

129129
dev_notice(dev, "enabled\n");
130130

131131
return 0;
132132

133-
e_free:
134-
kfree(ccp);
135-
136133
e_err:
137134
dev_notice(dev, "initialization failed\n");
138135
return ret;
@@ -145,8 +142,6 @@ static int ccp_platform_remove(struct platform_device *pdev)
145142

146143
ccp_destroy(ccp);
147144

148-
kfree(ccp);
149-
150145
dev_notice(dev, "disabled\n");
151146

152147
return 0;

0 commit comments

Comments
 (0)