Skip to content

Commit bd3400e

Browse files
Liangcai Fantorvalds
authored andcommitted
mm: khugepaged: recalculate min_free_kbytes after stopping khugepaged
When initializing transparent huge pages, min_free_kbytes would be calculated according to what khugepaged expected. So when transparent huge pages get disabled, min_free_kbytes should be recalculated instead of the higher value set by khugepaged. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Liangcai Fan <[email protected]> Signed-off-by: Chunyan Zhang <[email protected]> Cc: Mike Kravetz <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 8531fc6 commit bd3400e

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

include/linux/mm.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2453,6 +2453,7 @@ extern void memmap_init_range(unsigned long, int, unsigned long,
24532453
unsigned long, unsigned long, enum meminit_context,
24542454
struct vmem_altmap *, int migratetype);
24552455
extern void setup_per_zone_wmarks(void);
2456+
extern void calculate_min_free_kbytes(void);
24562457
extern int __meminit init_per_zone_wmark_min(void);
24572458
extern void mem_init(void);
24582459
extern void __init mmap_init(void);

mm/khugepaged.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2299,6 +2299,11 @@ static void set_recommended_min_free_kbytes(void)
22992299
int nr_zones = 0;
23002300
unsigned long recommended_min;
23012301

2302+
if (!khugepaged_enabled()) {
2303+
calculate_min_free_kbytes();
2304+
goto update_wmarks;
2305+
}
2306+
23022307
for_each_populated_zone(zone) {
23032308
/*
23042309
* We don't need to worry about fragmentation of
@@ -2334,6 +2339,8 @@ static void set_recommended_min_free_kbytes(void)
23342339

23352340
min_free_kbytes = recommended_min;
23362341
}
2342+
2343+
update_wmarks:
23372344
setup_per_zone_wmarks();
23382345
}
23392346

@@ -2355,12 +2362,11 @@ int start_stop_khugepaged(void)
23552362

23562363
if (!list_empty(&khugepaged_scan.mm_head))
23572364
wake_up_interruptible(&khugepaged_wait);
2358-
2359-
set_recommended_min_free_kbytes();
23602365
} else if (khugepaged_thread) {
23612366
kthread_stop(khugepaged_thread);
23622367
khugepaged_thread = NULL;
23632368
}
2369+
set_recommended_min_free_kbytes();
23642370
fail:
23652371
mutex_unlock(&khugepaged_mutex);
23662372
return err;

mm/page_alloc.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8469,7 +8469,7 @@ void setup_per_zone_wmarks(void)
84698469
* 8192MB: 11584k
84708470
* 16384MB: 16384k
84718471
*/
8472-
int __meminit init_per_zone_wmark_min(void)
8472+
void calculate_min_free_kbytes(void)
84738473
{
84748474
unsigned long lowmem_kbytes;
84758475
int new_min_free_kbytes;
@@ -8483,6 +8483,11 @@ int __meminit init_per_zone_wmark_min(void)
84838483
pr_warn("min_free_kbytes is not updated to %d because user defined value %d is preferred\n",
84848484
new_min_free_kbytes, user_min_free_kbytes);
84858485

8486+
}
8487+
8488+
int __meminit init_per_zone_wmark_min(void)
8489+
{
8490+
calculate_min_free_kbytes();
84868491
setup_per_zone_wmarks();
84878492
refresh_zone_stat_thresholds();
84888493
setup_per_zone_lowmem_reserve();

0 commit comments

Comments
 (0)