Skip to content

Commit bb2ff6c

Browse files
vsyrjalajnikula
authored andcommitted
drm: Disable dynamic debug as broken
CONFIG_DRM_USE_DYNAMIC_DEBUG breaks debug prints for (at least modular) drm drivers. The debug prints can be reinstated by manually frobbing /sys/module/drm/parameters/debug after the fact, but at that point the damage is done and all debugs from driver probe are lost. This makes drivers totally undebuggable. There's a more complete fix in progress [1], with further details, but we need this fixed in stable kernels. Mark the feature as broken and disable it by default, with hopes distros follow suit and disable it as well. [1] https://lore.kernel.org/r/[email protected] Fixes: 84ec672 ("drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro") Cc: Jim Cromie <[email protected]> Cc: Greg Kroah-Hartman <[email protected]> Cc: Maarten Lankhorst <[email protected]> Cc: Maxime Ripard <[email protected]> Cc: Thomas Zimmermann <[email protected]> Cc: David Airlie <[email protected]> Cc: Daniel Vetter <[email protected]> Cc: [email protected] Cc: <[email protected]> # v6.1+ Signed-off-by: Ville Syrjälä <[email protected]> Acked-by: Greg Kroah-Hartman <[email protected]> Acked-by: Jim Cromie <[email protected]> Acked-by: Maxime Ripard <[email protected]> Signed-off-by: Jani Nikula <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 7484a5b commit bb2ff6c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/gpu/drm/Kconfig

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ config DRM_DEBUG_MM
5353

5454
config DRM_USE_DYNAMIC_DEBUG
5555
bool "use dynamic debug to implement drm.debug"
56-
default y
56+
default n
57+
depends on BROKEN
5758
depends on DRM
5859
depends on DYNAMIC_DEBUG || DYNAMIC_DEBUG_CORE
5960
depends on JUMP_LABEL

0 commit comments

Comments
 (0)