Skip to content

Commit b7165bd

Browse files
yishaihjgunthorpe
authored andcommitted
IB/mlx5: Fix RSS Toeplitz setup to be aligned with the HW specification
The specification for the Toeplitz function doesn't require to set the key explicitly to be symmetric. In case a symmetric functionality is required a symmetric key can be simply used. Wrongly forcing the algorithm to symmetric causes the wrong packet distribution and a performance degradation. Link: https://lore.kernel.org/r/[email protected] Cc: <[email protected]> # 4.7 Fixes: 28d6137 ("IB/mlx5: Add RSS QP support") Signed-off-by: Yishai Hadas <[email protected]> Reviewed-by: Alex Vainman <[email protected]> Signed-off-by: Leon Romanovsky <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent d191152 commit b7165bd

File tree

1 file changed

+0
-1
lines changed
  • drivers/infiniband/hw/mlx5

1 file changed

+0
-1
lines changed

drivers/infiniband/hw/mlx5/qp.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1713,7 +1713,6 @@ static int create_rss_raw_qp_tir(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp,
17131713
}
17141714

17151715
MLX5_SET(tirc, tirc, rx_hash_fn, MLX5_RX_HASH_FN_TOEPLITZ);
1716-
MLX5_SET(tirc, tirc, rx_hash_symmetric, 1);
17171716
memcpy(rss_key, ucmd.rx_hash_key, len);
17181717
break;
17191718
}

0 commit comments

Comments
 (0)