Skip to content

Commit b0de545

Browse files
committed
nvme-pci: remove two deallocate zeroes quirks
The quirk was initially used as a signal to set the discard_zeroes_data queue limit because there were some use cases that relied on that behavior. The queue limit no longer exists as every user of it has been converted to use the write zeroes operation instead. The quirk now means to use a discard command as an alias to a write zeroes request. Two of the devices previously using the quirk support the write zeroes command directly, so these don't need or want to use discard when the desired operation is to write zeroes. Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Keith Busch <[email protected]>
1 parent 58a0c87 commit b0de545

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/nvme/host/pci.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3588,12 +3588,10 @@ static const struct pci_device_id nvme_id_table[] = {
35883588
NVME_QUIRK_DEALLOCATE_ZEROES, },
35893589
{ PCI_VDEVICE(INTEL, 0x0a54), /* Intel P4500/P4600 */
35903590
.driver_data = NVME_QUIRK_STRIPE_SIZE |
3591-
NVME_QUIRK_DEALLOCATE_ZEROES |
35923591
NVME_QUIRK_IGNORE_DEV_SUBNQN |
35933592
NVME_QUIRK_BOGUS_NID, },
35943593
{ PCI_VDEVICE(INTEL, 0x0a55), /* Dell Express Flash P4600 */
3595-
.driver_data = NVME_QUIRK_STRIPE_SIZE |
3596-
NVME_QUIRK_DEALLOCATE_ZEROES, },
3594+
.driver_data = NVME_QUIRK_STRIPE_SIZE, },
35973595
{ PCI_VDEVICE(INTEL, 0xf1a5), /* Intel 600P/P3100 */
35983596
.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
35993597
NVME_QUIRK_MEDIUM_PRIO_SQ |

0 commit comments

Comments
 (0)