Skip to content

Commit a5b2dcb

Browse files
Abhinav Kumarlumag
authored andcommitted
drm: improve the documentation of connector hpd ops
While making the changes in [1], it was noted that the documentation of the enable_hpd() and disable_hpd() does not make it clear that these ops should not try to do hpd state maintenance and should only enable/disable hpd related hardware for the connector. The state management of these calls to make sure these calls are balanced is handled by the DRM core and we should keep it that way to minimize the overhead in the drivers which implement these ops. [1]: https://patchwork.freedesktop.org/patch/558387/ Signed-off-by: Abhinav Kumar <[email protected]> Suggested-by: Laurent Pinchart <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]> Signed-off-by: Dmitry Baryshkov <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 5d86c15 commit a5b2dcb

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

include/drm/drm_modeset_helper_vtables.h

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1154,6 +1154,11 @@ struct drm_connector_helper_funcs {
11541154
* This operation is optional.
11551155
*
11561156
* This callback is used by the drm_kms_helper_poll_enable() helpers.
1157+
*
1158+
* This operation does not need to perform any hpd state tracking as
1159+
* the DRM core handles that maintenance and ensures the calls to enable
1160+
* and disable hpd are balanced.
1161+
*
11571162
*/
11581163
void (*enable_hpd)(struct drm_connector *connector);
11591164

@@ -1165,6 +1170,11 @@ struct drm_connector_helper_funcs {
11651170
* This operation is optional.
11661171
*
11671172
* This callback is used by the drm_kms_helper_poll_disable() helpers.
1173+
*
1174+
* This operation does not need to perform any hpd state tracking as
1175+
* the DRM core handles that maintenance and ensures the calls to enable
1176+
* and disable hpd are balanced.
1177+
*
11681178
*/
11691179
void (*disable_hpd)(struct drm_connector *connector);
11701180
};

0 commit comments

Comments
 (0)