Skip to content

Commit a2933a8

Browse files
liuhangbinPaolo Abeni
authored andcommitted
selftests: bonding: do not test arp/ns target with mode balance-alb/tlb
The prio_arp/ns tests hard code the mode to active-backup. At the same time, The balance-alb/tlb modes do not support arp/ns target. So remove the prio_arp/ns tests from the loop and only test active-backup mode. Fixes: 481b56e ("selftests: bonding: re-format bond option tests") Reported-by: Jay Vosburgh <[email protected]> Closes: https://lore.kernel.org/netdev/17415.1705965957@famine/ Signed-off-by: Hangbin Liu <[email protected]> Acked-by: Jay Vosburgh <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Paolo Abeni <[email protected]>
1 parent a717932 commit a2933a8

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tools/testing/selftests/drivers/net/bonding/bond_options.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ prio_arp()
162162
local mode=$1
163163

164164
for primary_reselect in 0 1 2; do
165-
prio_test "mode active-backup arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect"
165+
prio_test "mode $mode arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect"
166166
log_test "prio" "$mode arp_ip_target primary_reselect $primary_reselect"
167167
done
168168
}
@@ -178,7 +178,7 @@ prio_ns()
178178
fi
179179

180180
for primary_reselect in 0 1 2; do
181-
prio_test "mode active-backup arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect"
181+
prio_test "mode $mode arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect"
182182
log_test "prio" "$mode ns_ip6_target primary_reselect $primary_reselect"
183183
done
184184
}
@@ -194,9 +194,9 @@ prio()
194194

195195
for mode in $modes; do
196196
prio_miimon $mode
197-
prio_arp $mode
198-
prio_ns $mode
199197
done
198+
prio_arp "active-backup"
199+
prio_ns "active-backup"
200200
}
201201

202202
arp_validate_test()

0 commit comments

Comments
 (0)