Skip to content

Commit a150d12

Browse files
committed
netfilter: nft_meta: add inner match support
Add support for inner meta matching on: - NFT_META_PROTOCOL: to match on the ethertype, this can be used regardless tunnel protocol provides no link layer header, in that case nft_inner sets on the ethertype based on the IP header version field. - NFT_META_L4PROTO: to match on the layer 4 protocol. These meta expression are usually autogenerated as dependencies by userspace nftables. Signed-off-by: Pablo Neira Ayuso <[email protected]>
1 parent 0e795b3 commit a150d12

File tree

3 files changed

+76
-0
lines changed

3 files changed

+76
-0
lines changed

include/net/netfilter/nft_meta.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,10 @@ int nft_meta_set_validate(const struct nft_ctx *ctx,
4646

4747
bool nft_meta_get_reduce(struct nft_regs_track *track,
4848
const struct nft_expr *expr);
49+
50+
struct nft_inner_tun_ctx;
51+
void nft_meta_inner_eval(const struct nft_expr *expr,
52+
struct nft_regs *regs, const struct nft_pktinfo *pkt,
53+
struct nft_inner_tun_ctx *tun_ctx);
54+
4955
#endif

net/netfilter/nft_inner.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
#include <linux/netfilter/nf_tables.h>
1313
#include <net/netfilter/nf_tables_core.h>
1414
#include <net/netfilter/nf_tables.h>
15+
#include <net/netfilter/nft_meta.h>
1516
#include <net/netfilter/nf_tables_offload.h>
1617
#include <linux/tcp.h>
1718
#include <linux/udp.h>
@@ -28,11 +29,13 @@ struct __nft_expr {
2829
const struct nft_expr_ops *ops;
2930
union {
3031
struct nft_payload payload;
32+
struct nft_meta meta;
3133
} __attribute__((aligned(__alignof__(u64))));
3234
};
3335

3436
enum {
3537
NFT_INNER_EXPR_PAYLOAD,
38+
NFT_INNER_EXPR_META,
3639
};
3740

3841
struct nft_inner {
@@ -237,6 +240,9 @@ static void nft_inner_eval(const struct nft_expr *expr, struct nft_regs *regs,
237240
case NFT_INNER_EXPR_PAYLOAD:
238241
nft_payload_inner_eval((struct nft_expr *)&priv->expr, regs, pkt, tun_ctx);
239242
break;
243+
case NFT_INNER_EXPR_META:
244+
nft_meta_inner_eval((struct nft_expr *)&priv->expr, regs, pkt, tun_ctx);
245+
break;
240246
default:
241247
WARN_ON_ONCE(1);
242248
goto err;
@@ -306,6 +312,8 @@ static int nft_inner_init(const struct nft_ctx *ctx,
306312

307313
if (!strcmp(expr_info.ops->type->name, "payload"))
308314
priv->expr_type = NFT_INNER_EXPR_PAYLOAD;
315+
else if (!strcmp(expr_info.ops->type->name, "meta"))
316+
priv->expr_type = NFT_INNER_EXPR_META;
309317
else
310318
return -EINVAL;
311319

net/netfilter/nft_meta.c

Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -831,9 +831,71 @@ nft_meta_select_ops(const struct nft_ctx *ctx,
831831
return ERR_PTR(-EINVAL);
832832
}
833833

834+
static int nft_meta_inner_init(const struct nft_ctx *ctx,
835+
const struct nft_expr *expr,
836+
const struct nlattr * const tb[])
837+
{
838+
struct nft_meta *priv = nft_expr_priv(expr);
839+
unsigned int len;
840+
841+
priv->key = ntohl(nla_get_be32(tb[NFTA_META_KEY]));
842+
switch (priv->key) {
843+
case NFT_META_PROTOCOL:
844+
len = sizeof(u16);
845+
break;
846+
case NFT_META_L4PROTO:
847+
len = sizeof(u32);
848+
break;
849+
default:
850+
return -EOPNOTSUPP;
851+
}
852+
priv->len = len;
853+
854+
return nft_parse_register_store(ctx, tb[NFTA_META_DREG], &priv->dreg,
855+
NULL, NFT_DATA_VALUE, len);
856+
}
857+
858+
void nft_meta_inner_eval(const struct nft_expr *expr,
859+
struct nft_regs *regs,
860+
const struct nft_pktinfo *pkt,
861+
struct nft_inner_tun_ctx *tun_ctx)
862+
{
863+
const struct nft_meta *priv = nft_expr_priv(expr);
864+
u32 *dest = &regs->data[priv->dreg];
865+
866+
switch (priv->key) {
867+
case NFT_META_PROTOCOL:
868+
nft_reg_store16(dest, (__force u16)tun_ctx->llproto);
869+
break;
870+
case NFT_META_L4PROTO:
871+
if (!(tun_ctx->flags & NFT_PAYLOAD_CTX_INNER_TH))
872+
goto err;
873+
874+
nft_reg_store8(dest, tun_ctx->l4proto);
875+
break;
876+
default:
877+
WARN_ON_ONCE(1);
878+
goto err;
879+
}
880+
return;
881+
882+
err:
883+
regs->verdict.code = NFT_BREAK;
884+
}
885+
EXPORT_SYMBOL_GPL(nft_meta_inner_eval);
886+
887+
static const struct nft_expr_ops nft_meta_inner_ops = {
888+
.type = &nft_meta_type,
889+
.size = NFT_EXPR_SIZE(sizeof(struct nft_meta)),
890+
.init = nft_meta_inner_init,
891+
.dump = nft_meta_get_dump,
892+
/* direct call to nft_meta_inner_eval(). */
893+
};
894+
834895
struct nft_expr_type nft_meta_type __read_mostly = {
835896
.name = "meta",
836897
.select_ops = nft_meta_select_ops,
898+
.inner_ops = &nft_meta_inner_ops,
837899
.policy = nft_meta_policy,
838900
.maxattr = NFTA_META_MAX,
839901
.owner = THIS_MODULE,

0 commit comments

Comments
 (0)