Skip to content

Commit a10834a

Browse files
Jeroen de Borstdavem330
authored andcommitted
gve: Correct order of processing device options
The legacy raw addressing device option was processed before the new RDA queue format option. This caused the supported features mask, which is provided only on the RDA queue format option, not to be set. This disabled jumbo-frame support when using raw adressing. Fixes: 255489f ("gve: Add a jumbo-frame device option") Signed-off-by: Jeroen de Borst <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 75df1a2 commit a10834a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/net/ethernet/google/gve/gve_adminq.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -738,10 +738,7 @@ int gve_adminq_describe_device(struct gve_priv *priv)
738738
* is not set to GqiRda, choose the queue format in a priority order:
739739
* DqoRda, GqiRda, GqiQpl. Use GqiQpl as default.
740740
*/
741-
if (priv->queue_format == GVE_GQI_RDA_FORMAT) {
742-
dev_info(&priv->pdev->dev,
743-
"Driver is running with GQI RDA queue format.\n");
744-
} else if (dev_op_dqo_rda) {
741+
if (dev_op_dqo_rda) {
745742
priv->queue_format = GVE_DQO_RDA_FORMAT;
746743
dev_info(&priv->pdev->dev,
747744
"Driver is running with DQO RDA queue format.\n");
@@ -753,6 +750,9 @@ int gve_adminq_describe_device(struct gve_priv *priv)
753750
"Driver is running with GQI RDA queue format.\n");
754751
supported_features_mask =
755752
be32_to_cpu(dev_op_gqi_rda->supported_features_mask);
753+
} else if (priv->queue_format == GVE_GQI_RDA_FORMAT) {
754+
dev_info(&priv->pdev->dev,
755+
"Driver is running with GQI RDA queue format.\n");
756756
} else {
757757
priv->queue_format = GVE_GQI_QPL_FORMAT;
758758
if (dev_op_gqi_qpl)

0 commit comments

Comments
 (0)