Skip to content

Commit 9d4e6ab

Browse files
committed
slab: simplify init_kmem_cache_nodes() error handling
We don't need to call free_kmem_cache_nodes() immediately when failing to allocate a kmem_cache_node, because when we return 0, do_kmem_cache_create() calls __kmem_cache_release() which also performs free_kmem_cache_nodes(). Reviewed-by: Harry Yoo <[email protected]> Reviewed-by: Suren Baghdasaryan <[email protected]> Signed-off-by: Vlastimil Babka <[email protected]>
1 parent 212b0f0 commit 9d4e6ab

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

mm/slub.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5669,10 +5669,8 @@ static int init_kmem_cache_nodes(struct kmem_cache *s)
56695669
n = kmem_cache_alloc_node(kmem_cache_node,
56705670
GFP_KERNEL, node);
56715671

5672-
if (!n) {
5673-
free_kmem_cache_nodes(s);
5672+
if (!n)
56745673
return 0;
5675-
}
56765674

56775675
init_kmem_cache_node(n);
56785676
s->node[node] = n;

0 commit comments

Comments
 (0)