addrconf: refuse isatap eui64 for INADDR_ANY

shlusiak · davem330 · commit 9af28511be10 · 2009-05-19T16:02:02.000-07:00
A tunnel with no local ipv4 endpoint would otherwise use the
ISATAP linklocal address fe80::5efe:0:0, which is invalid. Rather not
add a linklocal address at all.

Signed-off-by: Sascha Hlusiak &lt;contact@saschahlusiak.de&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
@@ -1520,6 +1520,8 @@ static int addrconf_ifid_infiniband(u8 *eui, struct net_device *dev)
 
 int __ipv6_isatap_ifid(u8 *eui, __be32 addr)
 {
+	if (addr == 0)
+		return -1;
 	eui[0] = (ipv4_is_zeronet(addr) || ipv4_is_private_10(addr) ||
 		  ipv4_is_loopback(addr) || ipv4_is_linklocal_169(addr) ||
 		  ipv4_is_private_172(addr) || ipv4_is_test_192(addr) ||

Original file line number	Diff line number	Diff line change
`@@ -1520,6 +1520,8 @@ static int addrconf_ifid_infiniband(u8 eui, struct net_device dev)`
`1520`	`1520`
`1521`	`1521`	`int __ipv6_isatap_ifid(u8 *eui, __be32 addr)`
`1522`	`1522`	`{`
	`1523`	`+ if (addr == 0)`
	`1524`	`+ return -1;`
`1523`	`1525`	`eui[0] = (ipv4_is_zeronet(addr) \|\| ipv4_is_private_10(addr) \|\|`
`1524`	`1526`	`ipv4_is_loopback(addr) \|\| ipv4_is_linklocal_169(addr) \|\|`
`1525`	`1527`	`ipv4_is_private_172(addr) \|\| ipv4_is_test_192(addr) \|\|`