Skip to content

Commit 99df45c

Browse files
Dan Carpenterkuba-moo
authored andcommitted
sunhme: fix an IS_ERR() vs NULL check in probe
The devm_request_region() function does not return error pointers, it returns NULL on error. Fixes: 914d9b2 ("sunhme: switch to devres") Signed-off-by: Dan Carpenter <[email protected]> Reviewed-by: Sean Anderson <[email protected]> Reviewed-by: Rolf Eike Beer <[email protected]> Link: https://lore.kernel.org/r/Y0bWzJL8JknX8MUf@kili Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 30e9672 commit 99df45c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/ethernet/sun/sunhme.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2896,8 +2896,8 @@ static int happy_meal_pci_probe(struct pci_dev *pdev,
28962896

28972897
hpreg_res = devm_request_region(&pdev->dev, pci_resource_start(pdev, 0),
28982898
pci_resource_len(pdev, 0), DRV_NAME);
2899-
if (IS_ERR(hpreg_res)) {
2900-
err = PTR_ERR(hpreg_res);
2899+
if (!hpreg_res) {
2900+
err = -EBUSY;
29012901
dev_err(&pdev->dev, "Cannot obtain PCI resources, aborting.\n");
29022902
goto err_out_clear_quattro;
29032903
}

0 commit comments

Comments
 (0)