Skip to content

Commit 96449f9

Browse files
dhowellskuba-moo
authored andcommitted
net: Pass max frags into skb_append_pagefrags()
Pass the maximum number of fragments into skb_append_pagefrags() rather than using MAX_SKB_FRAGS so that it can be used from code that wants to specify sysctl_max_skb_frags. Signed-off-by: David Howells <[email protected]> cc: David Ahern <[email protected]> cc: Jens Axboe <[email protected]> cc: Matthew Wilcox <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]>
1 parent b841b90 commit 96449f9

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

include/linux/skbuff.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1383,7 +1383,7 @@ static inline int skb_pad(struct sk_buff *skb, int pad)
13831383
#define dev_kfree_skb(a) consume_skb(a)
13841384

13851385
int skb_append_pagefrags(struct sk_buff *skb, struct page *page,
1386-
int offset, size_t size);
1386+
int offset, size_t size, size_t max_frags);
13871387

13881388
struct skb_seq_state {
13891389
__u32 lower_offset;

net/core/skbuff.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4188,13 +4188,13 @@ unsigned int skb_find_text(struct sk_buff *skb, unsigned int from,
41884188
EXPORT_SYMBOL(skb_find_text);
41894189

41904190
int skb_append_pagefrags(struct sk_buff *skb, struct page *page,
4191-
int offset, size_t size)
4191+
int offset, size_t size, size_t max_frags)
41924192
{
41934193
int i = skb_shinfo(skb)->nr_frags;
41944194

41954195
if (skb_can_coalesce(skb, i, page, offset)) {
41964196
skb_frag_size_add(&skb_shinfo(skb)->frags[i - 1], size);
4197-
} else if (i < MAX_SKB_FRAGS) {
4197+
} else if (i < max_frags) {
41984198
skb_zcopy_downgrade_managed(skb);
41994199
get_page(page);
42004200
skb_fill_page_desc_noacc(skb, i, page, offset, size);

net/ipv4/ip_output.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1450,7 +1450,8 @@ ssize_t ip_append_page(struct sock *sk, struct flowi4 *fl4, struct page *page,
14501450
if (len > size)
14511451
len = size;
14521452

1453-
if (skb_append_pagefrags(skb, page, offset, len)) {
1453+
if (skb_append_pagefrags(skb, page, offset, len,
1454+
MAX_SKB_FRAGS)) {
14541455
err = -EMSGSIZE;
14551456
goto error;
14561457
}

net/unix/af_unix.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2349,7 +2349,7 @@ static ssize_t unix_stream_sendpage(struct socket *socket, struct page *page,
23492349
newskb = NULL;
23502350
}
23512351

2352-
if (skb_append_pagefrags(skb, page, offset, size)) {
2352+
if (skb_append_pagefrags(skb, page, offset, size, MAX_SKB_FRAGS)) {
23532353
tail = skb;
23542354
goto alloc_skb;
23552355
}

0 commit comments

Comments
 (0)