Skip to content

Commit 95073d0

Browse files
Sasha Neftinanguy11
authored andcommitted
igc: Change type of the 'igc_check_downshift' method
The 'igc_check_downshift' method always returns 0; there is no need for a return value so change the type of this method to void. Signed-off-by: Sasha Neftin <[email protected]> Tested-by: Naama Meir <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent 7241069 commit 95073d0

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

drivers/net/ethernet/intel/igc/igc_phy.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,18 +141,14 @@ void igc_power_down_phy_copper(struct igc_hw *hw)
141141
* igc_check_downshift - Checks whether a downshift in speed occurred
142142
* @hw: pointer to the HW structure
143143
*
144-
* Success returns 0, Failure returns 1
145-
*
146144
* A downshift is detected by querying the PHY link health.
147145
*/
148-
s32 igc_check_downshift(struct igc_hw *hw)
146+
void igc_check_downshift(struct igc_hw *hw)
149147
{
150148
struct igc_phy_info *phy = &hw->phy;
151149

152150
/* speed downshift not supported */
153151
phy->speed_downgraded = false;
154-
155-
return 0;
156152
}
157153

158154
/**

drivers/net/ethernet/intel/igc/igc_phy.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ s32 igc_phy_hw_reset(struct igc_hw *hw);
1111
s32 igc_get_phy_id(struct igc_hw *hw);
1212
s32 igc_phy_has_link(struct igc_hw *hw, u32 iterations,
1313
u32 usec_interval, bool *success);
14-
s32 igc_check_downshift(struct igc_hw *hw);
14+
void igc_check_downshift(struct igc_hw *hw);
1515
s32 igc_setup_copper_link(struct igc_hw *hw);
1616
void igc_power_up_phy_copper(struct igc_hw *hw);
1717
void igc_power_down_phy_copper(struct igc_hw *hw);

0 commit comments

Comments
 (0)