Skip to content

Commit 936f060

Browse files
oneukumdavem330
authored andcommitted
kaweth: remove obsolete debugging statements
SOme statements in the driver only served to inform which functions were entered. Ftrace can do that just as good without needing memory. Remove the statements. Signed-off-by: Oliver Neukum <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 72e8d5f commit 936f060

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

drivers/net/usb/kaweth.c

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,6 @@ static int kaweth_control(struct kaweth_device *kaweth,
265265
struct usb_ctrlrequest *dr;
266266
int retval;
267267

268-
netdev_dbg(kaweth->net, "kaweth_control()\n");
269-
270268
if(in_interrupt()) {
271269
netdev_dbg(kaweth->net, "in_interrupt()\n");
272270
return -EBUSY;
@@ -300,8 +298,6 @@ static int kaweth_read_configuration(struct kaweth_device *kaweth)
300298
{
301299
int retval;
302300

303-
netdev_dbg(kaweth->net, "Reading kaweth configuration\n");
304-
305301
retval = kaweth_control(kaweth,
306302
usb_rcvctrlpipe(kaweth->dev, 0),
307303
KAWETH_COMMAND_GET_ETHERNET_DESC,
@@ -451,8 +447,6 @@ static int kaweth_trigger_firmware(struct kaweth_device *kaweth,
451447
kaweth->firmware_buf[6] = 0x00;
452448
kaweth->firmware_buf[7] = 0x00;
453449

454-
netdev_dbg(kaweth->net, "Triggering firmware\n");
455-
456450
return kaweth_control(kaweth,
457451
usb_sndctrlpipe(kaweth->dev, 0),
458452
KAWETH_COMMAND_SCAN,
@@ -471,7 +465,6 @@ static int kaweth_reset(struct kaweth_device *kaweth)
471465
{
472466
int result;
473467

474-
netdev_dbg(kaweth->net, "kaweth_reset(%p)\n", kaweth);
475468
result = usb_reset_configuration(kaweth->dev);
476469
mdelay(10);
477470

@@ -685,8 +678,6 @@ static int kaweth_open(struct net_device *net)
685678
struct kaweth_device *kaweth = netdev_priv(net);
686679
int res;
687680

688-
netdev_dbg(kaweth->net, "Opening network device.\n");
689-
690681
res = usb_autopm_get_interface(kaweth->intf);
691682
if (res) {
692683
dev_err(&kaweth->intf->dev, "Interface cannot be resumed.\n");
@@ -951,7 +942,6 @@ static int kaweth_suspend(struct usb_interface *intf, pm_message_t message)
951942
struct kaweth_device *kaweth = usb_get_intfdata(intf);
952943
unsigned long flags;
953944

954-
dev_dbg(&intf->dev, "Suspending device\n");
955945
spin_lock_irqsave(&kaweth->device_lock, flags);
956946
kaweth->status |= KAWETH_STATUS_SUSPENDING;
957947
spin_unlock_irqrestore(&kaweth->device_lock, flags);
@@ -968,7 +958,6 @@ static int kaweth_resume(struct usb_interface *intf)
968958
struct kaweth_device *kaweth = usb_get_intfdata(intf);
969959
unsigned long flags;
970960

971-
dev_dbg(&intf->dev, "Resuming device\n");
972961
spin_lock_irqsave(&kaweth->device_lock, flags);
973962
kaweth->status &= ~KAWETH_STATUS_SUSPENDING;
974963
spin_unlock_irqrestore(&kaweth->device_lock, flags);
@@ -1190,8 +1179,6 @@ static int kaweth_probe(
11901179
dev_info(dev, "kaweth interface created at %s\n",
11911180
kaweth->net->name);
11921181

1193-
dev_dbg(dev, "Kaweth probe returning.\n");
1194-
11951182
return 0;
11961183

11971184
err_intfdata:
@@ -1219,8 +1206,6 @@ static void kaweth_disconnect(struct usb_interface *intf)
12191206
struct kaweth_device *kaweth = usb_get_intfdata(intf);
12201207
struct net_device *netdev;
12211208

1222-
dev_info(&intf->dev, "Unregistering\n");
1223-
12241209
usb_set_intfdata(intf, NULL);
12251210
if (!kaweth) {
12261211
dev_warn(&intf->dev, "unregistering non-existent device\n");

0 commit comments

Comments
 (0)