Skip to content

Commit 8e9d5ea

Browse files
Stefan Roeschakpm00
authored andcommitted
mm: add bdi_set_strict_limit() function
Patch series "mm/block: add bdi sysfs knobs", v4. At meta network block devices (nbd) are used to implement remote block storage. In testing and during production it has been observed that these network block devices can consume a huge portion of the dirty writeback cache and writeback can take a considerable time. To be able to give stricter limits, I'm proposing the following changes: 1) introduce strictlimit knob Currently the max_ratio knob exists to limit the dirty_memory. However this knob only applies once (dirty_ratio + dirty_background_ratio) / 2 has been reached. With the BDI_CAP_STRICTLIMIT flag, the max_ratio can be applied without reaching that limit. This change exposes that knob. This knob can also be useful for NFS, fuse filesystems and USB devices. 2) Use part of 1000000 internal calculation The max_ratio is based on percentage. With the current machine sizes percentage values can be very high (1% of a 256GB main memory is already 2.5GB). This change uses part of 1000000 instead of percentages for the internal calculations. 3) Introduce two new sysfs knobs: min_bytes and max_bytes. Currently all calculations are based on ratio, but for a user it often more convenient to specify a limit in bytes. The new knobs will not store bytes values, instead they will translate the byte value to a corresponding ratio. As the internal values are now part of 1000, the ratio is closer to the specified value. However the value should be more seen as an approximation as it can fluctuate over time. 3) Introduce two new sysfs knobs: min_ratio_fine and max_ratio_fine. The granularity for the existing sysfs bdi knobs min_ratio and max_ratio is based on percentage values. The new sysfs bdi knobs min_ratio_fine and max_ratio_fine allow to specify the ratio as part of 1 million. This patch (of 20): This adds the bdi_set_strict_limit function to be able to set/unset the BDI_CAP_STRICTLIMIT flag. Link: https://lkml.kernel.org/r/[email protected] Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Stefan Roesch <[email protected]> Cc: Jens Axboe <[email protected]> Cc: Chris Mason <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 845aad0 commit 8e9d5ea

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

include/linux/backing-dev.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ static inline unsigned long wb_stat_error(void)
104104

105105
int bdi_set_min_ratio(struct backing_dev_info *bdi, unsigned int min_ratio);
106106
int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ratio);
107+
int bdi_set_strict_limit(struct backing_dev_info *bdi, unsigned int strict_limit);
107108

108109
/*
109110
* Flags in backing_dev_info::capability

mm/page-writeback.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -698,6 +698,21 @@ int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned max_ratio)
698698
}
699699
EXPORT_SYMBOL(bdi_set_max_ratio);
700700

701+
int bdi_set_strict_limit(struct backing_dev_info *bdi, unsigned int strict_limit)
702+
{
703+
if (strict_limit > 1)
704+
return -EINVAL;
705+
706+
spin_lock_bh(&bdi_lock);
707+
if (strict_limit)
708+
bdi->capabilities |= BDI_CAP_STRICTLIMIT;
709+
else
710+
bdi->capabilities &= ~BDI_CAP_STRICTLIMIT;
711+
spin_unlock_bh(&bdi_lock);
712+
713+
return 0;
714+
}
715+
701716
static unsigned long dirty_freerun_ceiling(unsigned long thresh,
702717
unsigned long bg_thresh)
703718
{

0 commit comments

Comments
 (0)