Skip to content

Commit 8c3b55a

Browse files
Linus Walleijdtor
authored andcommitted
Input: atmel_mxt_ts - fix lost interrupts
After commit 74d905d devices requiring the workaround for edge triggered interrupts stopped working. The hardware needs the quirk to be used before even proceeding to check if the quirk is needed because mxt_acquire_irq() is called before mxt_check_retrigen() is called and at this point pending IRQs need to be checked, and if the workaround is not active, all interrupts will be lost from this point. Solve this by switching the calls around. Reported-by: Andre Müller <[email protected]> Tested-by: Andre Müller <[email protected]> Suggested-by: Dmitry Torokhov <[email protected]> Fixes: 74d905d ("Input: atmel_mxt_ts - only read messages in mxt_acquire_irq() when necessary") Signed-off-by: Linus Walleij <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dmitry Torokhov <[email protected]>
1 parent 2aab156 commit 8c3b55a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/input/touchscreen/atmel_mxt_ts.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2183,11 +2183,11 @@ static int mxt_initialize(struct mxt_data *data)
21832183
msleep(MXT_FW_RESET_TIME);
21842184
}
21852185

2186-
error = mxt_acquire_irq(data);
2186+
error = mxt_check_retrigen(data);
21872187
if (error)
21882188
return error;
21892189

2190-
error = mxt_check_retrigen(data);
2190+
error = mxt_acquire_irq(data);
21912191
if (error)
21922192
return error;
21932193

0 commit comments

Comments
 (0)