Skip to content

Commit 85e444a

Browse files
abelvesasuperna9999
authored andcommitted
drm/bridge: Fix assignment of the of_node of the parent to aux bridge
The assignment of the of_node to the aux bridge needs to mark the of_node as reused as well, otherwise resource providers like pinctrl will report a gpio as already requested by a different device when both pinconf and gpios property are present. Fix that by using the device_set_of_node_from_dev() helper instead. Fixes: 6914968 ("drm/bridge: properly refcount DT nodes in aux bridge drivers") Cc: [email protected] # 6.8 Cc: Dmitry Baryshkov <[email protected]> Signed-off-by: Abel Vesa <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Reviewed-by: Neil Armstrong <[email protected]> Link: https://lore.kernel.org/r/20241018-drm-aux-bridge-mark-of-node-reused-v2-1-aeed1b445c7d@linaro.org Signed-off-by: Neil Armstrong <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/20241018-drm-aux-bridge-mark-of-node-reused-v2-1-aeed1b445c7d@linaro.org
1 parent 83f0007 commit 85e444a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/gpu/drm/bridge/aux-bridge.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,10 @@ int drm_aux_bridge_register(struct device *parent)
5858
adev->id = ret;
5959
adev->name = "aux_bridge";
6060
adev->dev.parent = parent;
61-
adev->dev.of_node = of_node_get(parent->of_node);
6261
adev->dev.release = drm_aux_bridge_release;
6362

63+
device_set_of_node_from_dev(&adev->dev, parent);
64+
6465
ret = auxiliary_device_init(adev);
6566
if (ret) {
6667
ida_free(&drm_aux_bridge_ida, adev->id);

0 commit comments

Comments
 (0)