Skip to content

Commit 84d767a

Browse files
jpanisbldavem330
authored andcommitted
net: ethernet: ti: Add desc_infos member to struct k3_cppi_desc_pool
This patch introduces a member and the related accessors which can be used to store descriptor specific additional information. This member can store, for instance, an ID to differentiate a skb TX buffer type from a xdpf TX buffer type. Signed-off-by: Julien Panis <[email protected]> Reviewed-by: Jacob Keller <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent cd8ff81 commit 84d767a

File tree

2 files changed

+33
-5
lines changed

2 files changed

+33
-5
lines changed

drivers/net/ethernet/ti/k3-cppi-desc-pool.c

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ struct k3_cppi_desc_pool {
2222
size_t mem_size;
2323
size_t num_desc;
2424
struct gen_pool *gen_pool;
25+
void **desc_infos;
2526
};
2627

2728
void k3_cppi_desc_pool_destroy(struct k3_cppi_desc_pool *pool)
@@ -37,7 +38,11 @@ void k3_cppi_desc_pool_destroy(struct k3_cppi_desc_pool *pool)
3738
dma_free_coherent(pool->dev, pool->mem_size, pool->cpumem,
3839
pool->dma_addr);
3940

41+
kfree(pool->desc_infos);
42+
4043
gen_pool_destroy(pool->gen_pool); /* frees pool->name */
44+
45+
kfree(pool);
4146
}
4247
EXPORT_SYMBOL_GPL(k3_cppi_desc_pool_destroy);
4348

@@ -50,7 +55,7 @@ k3_cppi_desc_pool_create_name(struct device *dev, size_t size,
5055
const char *pool_name = NULL;
5156
int ret = -ENOMEM;
5257

53-
pool = devm_kzalloc(dev, sizeof(*pool), GFP_KERNEL);
58+
pool = kzalloc(sizeof(*pool), GFP_KERNEL);
5459
if (!pool)
5560
return ERR_PTR(ret);
5661

@@ -62,18 +67,21 @@ k3_cppi_desc_pool_create_name(struct device *dev, size_t size,
6267
pool_name = kstrdup_const(name ? name : dev_name(pool->dev),
6368
GFP_KERNEL);
6469
if (!pool_name)
65-
return ERR_PTR(-ENOMEM);
70+
goto gen_pool_create_fail;
6671

6772
pool->gen_pool = gen_pool_create(ilog2(pool->desc_size), -1);
6873
if (!pool->gen_pool) {
69-
ret = -ENOMEM;
70-
dev_err(pool->dev, "pool create failed %d\n", ret);
7174
kfree_const(pool_name);
7275
goto gen_pool_create_fail;
7376
}
7477

7578
pool->gen_pool->name = pool_name;
7679

80+
pool->desc_infos = kcalloc(pool->num_desc,
81+
sizeof(*pool->desc_infos), GFP_KERNEL);
82+
if (!pool->desc_infos)
83+
goto gen_pool_desc_infos_alloc_fail;
84+
7785
pool->cpumem = dma_alloc_coherent(pool->dev, pool->mem_size,
7886
&pool->dma_addr, GFP_KERNEL);
7987

@@ -94,9 +102,11 @@ k3_cppi_desc_pool_create_name(struct device *dev, size_t size,
94102
dma_free_coherent(pool->dev, pool->mem_size, pool->cpumem,
95103
pool->dma_addr);
96104
dma_alloc_fail:
105+
kfree(pool->desc_infos);
106+
gen_pool_desc_infos_alloc_fail:
97107
gen_pool_destroy(pool->gen_pool); /* frees pool->name */
98108
gen_pool_create_fail:
99-
devm_kfree(pool->dev, pool);
109+
kfree(pool);
100110
return ERR_PTR(ret);
101111
}
102112
EXPORT_SYMBOL_GPL(k3_cppi_desc_pool_create_name);
@@ -144,5 +154,19 @@ void *k3_cppi_desc_pool_cpuaddr(const struct k3_cppi_desc_pool *pool)
144154
}
145155
EXPORT_SYMBOL_GPL(k3_cppi_desc_pool_cpuaddr);
146156

157+
void k3_cppi_desc_pool_desc_info_set(struct k3_cppi_desc_pool *pool,
158+
int desc_idx, void *info)
159+
{
160+
pool->desc_infos[desc_idx] = info;
161+
}
162+
EXPORT_SYMBOL_GPL(k3_cppi_desc_pool_desc_info_set);
163+
164+
void *k3_cppi_desc_pool_desc_info(const struct k3_cppi_desc_pool *pool,
165+
int desc_idx)
166+
{
167+
return pool->desc_infos[desc_idx];
168+
}
169+
EXPORT_SYMBOL_GPL(k3_cppi_desc_pool_desc_info);
170+
147171
MODULE_LICENSE("GPL");
148172
MODULE_DESCRIPTION("TI K3 CPPI5 descriptors pool API");

drivers/net/ethernet/ti/k3-cppi-desc-pool.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,9 @@ void k3_cppi_desc_pool_free(struct k3_cppi_desc_pool *pool, void *addr);
2828
size_t k3_cppi_desc_pool_avail(struct k3_cppi_desc_pool *pool);
2929
size_t k3_cppi_desc_pool_desc_size(const struct k3_cppi_desc_pool *pool);
3030
void *k3_cppi_desc_pool_cpuaddr(const struct k3_cppi_desc_pool *pool);
31+
void k3_cppi_desc_pool_desc_info_set(struct k3_cppi_desc_pool *pool,
32+
int desc_idx, void *info);
33+
void *k3_cppi_desc_pool_desc_info(const struct k3_cppi_desc_pool *pool,
34+
int desc_idx);
3135

3236
#endif /* K3_CPPI_DESC_POOL_H_ */

0 commit comments

Comments
 (0)