Skip to content

Commit 7d885d0

Browse files
sowminivdavem330
authored andcommitted
RDS: Remove stale function rds_send_get_message()
The only caller of rds_send_get_message() was rds_iw_send_cq_comp_handler() which was removed as part of commit dcdede0 ("RDS: Drop stale iWARP RDMA transport"), so remove rds_send_get_message() for the same reason. Signed-off-by: Sowmini Varadhan <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 5c3d274 commit 7d885d0

File tree

2 files changed

+0
-38
lines changed

2 files changed

+0
-38
lines changed

net/rds/rds.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -789,8 +789,6 @@ void rds_send_drop_acked(struct rds_connection *conn, u64 ack,
789789
void rds_send_path_drop_acked(struct rds_conn_path *cp, u64 ack,
790790
is_acked_func is_acked);
791791
int rds_send_pong(struct rds_connection *conn, __be16 dport);
792-
struct rds_message *rds_send_get_message(struct rds_connection *,
793-
struct rm_rdma_op *);
794792

795793
/* rdma.c */
796794
void rds_rdma_unuse(struct rds_sock *rs, u32 r_key, int force);

net/rds/send.c

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -565,42 +565,6 @@ __rds_send_complete(struct rds_sock *rs, struct rds_message *rm, int status)
565565
/* No need to wake the app - caller does this */
566566
}
567567

568-
/*
569-
* This is called from the IB send completion when we detect
570-
* a RDMA operation that failed with remote access error.
571-
* So speed is not an issue here.
572-
*/
573-
struct rds_message *rds_send_get_message(struct rds_connection *conn,
574-
struct rm_rdma_op *op)
575-
{
576-
struct rds_message *rm, *tmp, *found = NULL;
577-
unsigned long flags;
578-
579-
spin_lock_irqsave(&conn->c_lock, flags);
580-
581-
list_for_each_entry_safe(rm, tmp, &conn->c_retrans, m_conn_item) {
582-
if (&rm->rdma == op) {
583-
atomic_inc(&rm->m_refcount);
584-
found = rm;
585-
goto out;
586-
}
587-
}
588-
589-
list_for_each_entry_safe(rm, tmp, &conn->c_send_queue, m_conn_item) {
590-
if (&rm->rdma == op) {
591-
atomic_inc(&rm->m_refcount);
592-
found = rm;
593-
break;
594-
}
595-
}
596-
597-
out:
598-
spin_unlock_irqrestore(&conn->c_lock, flags);
599-
600-
return found;
601-
}
602-
EXPORT_SYMBOL_GPL(rds_send_get_message);
603-
604568
/*
605569
* This removes messages from the socket's list if they're on it. The list
606570
* argument must be private to the caller, we must be able to modify it

0 commit comments

Comments
 (0)