Skip to content

Commit 7ca972a

Browse files
committed
erofs: remove ENOATTR definition
ENOATTR is not defined in Linux; use ENODATA instead. Signed-off-by: Gao Xiang <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent f768685 commit 7ca972a

File tree

2 files changed

+16
-19
lines changed

2 files changed

+16
-19
lines changed

fs/erofs/xattr.c

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ static int erofs_init_inode_xattrs(struct inode *inode)
7272
ret = -EFSCORRUPTED;
7373
goto out_unlock; /* xattr ondisk layout error */
7474
}
75-
ret = -ENOATTR;
75+
ret = -ENODATA;
7676
goto out_unlock;
7777
}
7878

@@ -266,20 +266,20 @@ static int erofs_getxattr_foreach(struct erofs_xattr_iter *it)
266266
(entry.e_name_index & EROFS_XATTR_LONG_PREFIX_MASK);
267267

268268
if (pf >= sbi->xattr_prefixes + sbi->xattr_prefix_count)
269-
return -ENOATTR;
269+
return -ENODATA;
270270

271271
if (it->index != pf->prefix->base_index ||
272272
it->name.len != entry.e_name_len + pf->infix_len)
273-
return -ENOATTR;
273+
return -ENODATA;
274274

275275
if (memcmp(it->name.name, pf->prefix->infix, pf->infix_len))
276-
return -ENOATTR;
276+
return -ENODATA;
277277

278278
it->infix_len = pf->infix_len;
279279
} else {
280280
if (it->index != entry.e_name_index ||
281281
it->name.len != entry.e_name_len)
282-
return -ENOATTR;
282+
return -ENODATA;
283283

284284
it->infix_len = 0;
285285
}
@@ -295,7 +295,7 @@ static int erofs_getxattr_foreach(struct erofs_xattr_iter *it)
295295
entry.e_name_len - processed);
296296
if (memcmp(it->name.name + it->infix_len + processed,
297297
it->kaddr, slice))
298-
return -ENOATTR;
298+
return -ENODATA;
299299
it->pos += slice;
300300
}
301301

@@ -323,7 +323,7 @@ static int erofs_xattr_iter_inline(struct erofs_xattr_iter *it,
323323
sizeof(u32) * vi->xattr_shared_count;
324324
if (xattr_header_sz >= vi->xattr_isize) {
325325
DBG_BUGON(xattr_header_sz > vi->xattr_isize);
326-
return -ENOATTR;
326+
return -ENODATA;
327327
}
328328

329329
remaining = vi->xattr_isize - xattr_header_sz;
@@ -347,7 +347,7 @@ static int erofs_xattr_iter_inline(struct erofs_xattr_iter *it,
347347
ret = erofs_getxattr_foreach(it);
348348
else
349349
ret = erofs_listxattr_foreach(it);
350-
if ((getxattr && ret != -ENOATTR) || (!getxattr && ret))
350+
if ((getxattr && ret != -ENODATA) || (!getxattr && ret))
351351
break;
352352

353353
it->pos = next_pos;
@@ -362,7 +362,7 @@ static int erofs_xattr_iter_shared(struct erofs_xattr_iter *it,
362362
struct super_block *const sb = it->sb;
363363
struct erofs_sb_info *sbi = EROFS_SB(sb);
364364
unsigned int i;
365-
int ret = -ENOATTR;
365+
int ret = -ENODATA;
366366

367367
for (i = 0; i < vi->xattr_shared_count; ++i) {
368368
it->pos = erofs_pos(sb, sbi->xattr_blkaddr) +
@@ -375,7 +375,7 @@ static int erofs_xattr_iter_shared(struct erofs_xattr_iter *it,
375375
ret = erofs_getxattr_foreach(it);
376376
else
377377
ret = erofs_listxattr_foreach(it);
378-
if ((getxattr && ret != -ENOATTR) || (!getxattr && ret))
378+
if ((getxattr && ret != -ENODATA) || (!getxattr && ret))
379379
break;
380380
}
381381
return ret;
@@ -403,7 +403,7 @@ int erofs_getxattr(struct inode *inode, int index, const char *name,
403403
EROFS_XATTR_FILTER_SEED + index);
404404
hashbit &= EROFS_XATTR_FILTER_BITS - 1;
405405
if (vi->xattr_name_filter & (1U << hashbit))
406-
return -ENOATTR;
406+
return -ENODATA;
407407
}
408408

409409
it.index = index;
@@ -419,7 +419,7 @@ int erofs_getxattr(struct inode *inode, int index, const char *name,
419419
it.buffer_ofs = 0;
420420

421421
ret = erofs_xattr_iter_inline(&it, inode, true);
422-
if (ret == -ENOATTR)
422+
if (ret == -ENODATA)
423423
ret = erofs_xattr_iter_shared(&it, inode, true);
424424
erofs_put_metabuf(&it.buf);
425425
return ret ? ret : it.buffer_ofs;
@@ -432,7 +432,7 @@ ssize_t erofs_listxattr(struct dentry *dentry, char *buffer, size_t buffer_size)
432432
struct inode *inode = d_inode(dentry);
433433

434434
ret = erofs_init_inode_xattrs(inode);
435-
if (ret == -ENOATTR)
435+
if (ret == -ENODATA)
436436
return 0;
437437
if (ret)
438438
return ret;
@@ -446,9 +446,9 @@ ssize_t erofs_listxattr(struct dentry *dentry, char *buffer, size_t buffer_size)
446446
it.buffer_ofs = 0;
447447

448448
ret = erofs_xattr_iter_inline(&it, inode, false);
449-
if (!ret || ret == -ENOATTR)
449+
if (!ret || ret == -ENODATA)
450450
ret = erofs_xattr_iter_shared(&it, inode, false);
451-
if (ret == -ENOATTR)
451+
if (ret == -ENODATA)
452452
ret = 0;
453453
erofs_put_metabuf(&it.buf);
454454
return ret ? ret : it.buffer_ofs;
@@ -539,7 +539,7 @@ struct posix_acl *erofs_get_acl(struct inode *inode, int type, bool rcu)
539539
rc = erofs_getxattr(inode, prefix, "", value, rc);
540540
}
541541

542-
if (rc == -ENOATTR)
542+
if (rc == -ENODATA)
543543
acl = NULL;
544544
else if (rc < 0)
545545
acl = ERR_PTR(rc);

fs/erofs/xattr.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@
1010
#include <linux/posix_acl_xattr.h>
1111
#include <linux/xattr.h>
1212

13-
/* Attribute not found */
14-
#define ENOATTR ENODATA
15-
1613
#ifdef CONFIG_EROFS_FS_XATTR
1714
extern const struct xattr_handler erofs_xattr_user_handler;
1815
extern const struct xattr_handler erofs_xattr_trusted_handler;

0 commit comments

Comments
 (0)