Skip to content

Commit 77cc7ae

Browse files
Wu Fengguangdavem330
authored andcommitted
RDS: IB: fix ifnullfree.cocci warnings
net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Signed-off-by: Fengguang Wu <[email protected]> Acked-by: Santosh Shilimkar <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent dfcb9f4 commit 77cc7ae

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

net/rds/ib.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,7 @@ static void rds_ib_dev_free(struct work_struct *work)
111111
kfree(i_ipaddr);
112112
}
113113

114-
if (rds_ibdev->vector_load)
115-
kfree(rds_ibdev->vector_load);
114+
kfree(rds_ibdev->vector_load);
116115

117116
kfree(rds_ibdev);
118117
}

0 commit comments

Comments
 (0)