Skip to content

Commit 726282a

Browse files
Gilad Ben-Yossefklassert
authored andcommitted
IPsec: do not ignore crypto err in ah6 input
ah6 input processing uses the asynchronous hash crypto API which supplies an error code as part of the operation completion but the error code was being ignored. Treat a crypto API error indication as a verification failure. While a crypto API reported error would almost certainly result in a memcpy of the digest failing anyway and thus the security risk seems minor, performing a memory compare on what might be uninitialized memory is wrong. Signed-off-by: Gilad Ben-Yossef <[email protected]> Signed-off-by: Steffen Klassert <[email protected]>
1 parent ebd89a2 commit 726282a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

net/ipv6/ah6.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -474,6 +474,9 @@ static void ah6_input_done(struct crypto_async_request *base, int err)
474474
int hdr_len = skb_network_header_len(skb);
475475
int ah_hlen = (ah->hdrlen + 2) << 2;
476476

477+
if (err)
478+
goto out;
479+
477480
work_iph = AH_SKB_CB(skb)->tmp;
478481
auth_data = ah_tmp_auth(work_iph, hdr_len);
479482
icv = ah_tmp_icv(ahp->ahash, auth_data, ahp->icv_trunc_len);

0 commit comments

Comments
 (0)