Skip to content

Commit 6fd2c17

Browse files
j-alonsodavem330
j-alonso
authored and
davem330
committed
Revert "net: usb: ax88179_178a needs FLAG_SEND_ZLP"
This reverts commit 36a15e1. The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware versions that have no issues. The FLAG_SEND_ZLP is not safe to use in this context. See: https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378 The original problem needs another way to solve. Fixes: 36a15e1 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP") Cc: [email protected] Reported-by: Ronald Wahl <[email protected]> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216327 Link: https://bugs.archlinux.org/task/75491 Signed-off-by: Jose Alonso <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 2cd0e8d commit 6fd2c17

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

‎drivers/net/usb/ax88179_178a.c‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1680,7 +1680,7 @@ static const struct driver_info ax88179_info = {
16801680
.link_reset = ax88179_link_reset,
16811681
.reset = ax88179_reset,
16821682
.stop = ax88179_stop,
1683-
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
1683+
.flags = FLAG_ETHER | FLAG_FRAMING_AX,
16841684
.rx_fixup = ax88179_rx_fixup,
16851685
.tx_fixup = ax88179_tx_fixup,
16861686
};
@@ -1693,7 +1693,7 @@ static const struct driver_info ax88178a_info = {
16931693
.link_reset = ax88179_link_reset,
16941694
.reset = ax88179_reset,
16951695
.stop = ax88179_stop,
1696-
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
1696+
.flags = FLAG_ETHER | FLAG_FRAMING_AX,
16971697
.rx_fixup = ax88179_rx_fixup,
16981698
.tx_fixup = ax88179_tx_fixup,
16991699
};
@@ -1706,7 +1706,7 @@ static const struct driver_info cypress_GX3_info = {
17061706
.link_reset = ax88179_link_reset,
17071707
.reset = ax88179_reset,
17081708
.stop = ax88179_stop,
1709-
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
1709+
.flags = FLAG_ETHER | FLAG_FRAMING_AX,
17101710
.rx_fixup = ax88179_rx_fixup,
17111711
.tx_fixup = ax88179_tx_fixup,
17121712
};
@@ -1719,7 +1719,7 @@ static const struct driver_info dlink_dub1312_info = {
17191719
.link_reset = ax88179_link_reset,
17201720
.reset = ax88179_reset,
17211721
.stop = ax88179_stop,
1722-
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
1722+
.flags = FLAG_ETHER | FLAG_FRAMING_AX,
17231723
.rx_fixup = ax88179_rx_fixup,
17241724
.tx_fixup = ax88179_tx_fixup,
17251725
};
@@ -1732,7 +1732,7 @@ static const struct driver_info sitecom_info = {
17321732
.link_reset = ax88179_link_reset,
17331733
.reset = ax88179_reset,
17341734
.stop = ax88179_stop,
1735-
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
1735+
.flags = FLAG_ETHER | FLAG_FRAMING_AX,
17361736
.rx_fixup = ax88179_rx_fixup,
17371737
.tx_fixup = ax88179_tx_fixup,
17381738
};
@@ -1745,7 +1745,7 @@ static const struct driver_info samsung_info = {
17451745
.link_reset = ax88179_link_reset,
17461746
.reset = ax88179_reset,
17471747
.stop = ax88179_stop,
1748-
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
1748+
.flags = FLAG_ETHER | FLAG_FRAMING_AX,
17491749
.rx_fixup = ax88179_rx_fixup,
17501750
.tx_fixup = ax88179_tx_fixup,
17511751
};
@@ -1758,7 +1758,7 @@ static const struct driver_info lenovo_info = {
17581758
.link_reset = ax88179_link_reset,
17591759
.reset = ax88179_reset,
17601760
.stop = ax88179_stop,
1761-
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
1761+
.flags = FLAG_ETHER | FLAG_FRAMING_AX,
17621762
.rx_fixup = ax88179_rx_fixup,
17631763
.tx_fixup = ax88179_tx_fixup,
17641764
};
@@ -1771,7 +1771,7 @@ static const struct driver_info belkin_info = {
17711771
.link_reset = ax88179_link_reset,
17721772
.reset = ax88179_reset,
17731773
.stop = ax88179_stop,
1774-
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
1774+
.flags = FLAG_ETHER | FLAG_FRAMING_AX,
17751775
.rx_fixup = ax88179_rx_fixup,
17761776
.tx_fixup = ax88179_tx_fixup,
17771777
};
@@ -1784,7 +1784,7 @@ static const struct driver_info toshiba_info = {
17841784
.link_reset = ax88179_link_reset,
17851785
.reset = ax88179_reset,
17861786
.stop = ax88179_stop,
1787-
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
1787+
.flags = FLAG_ETHER | FLAG_FRAMING_AX,
17881788
.rx_fixup = ax88179_rx_fixup,
17891789
.tx_fixup = ax88179_tx_fixup,
17901790
};
@@ -1797,7 +1797,7 @@ static const struct driver_info mct_info = {
17971797
.link_reset = ax88179_link_reset,
17981798
.reset = ax88179_reset,
17991799
.stop = ax88179_stop,
1800-
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
1800+
.flags = FLAG_ETHER | FLAG_FRAMING_AX,
18011801
.rx_fixup = ax88179_rx_fixup,
18021802
.tx_fixup = ax88179_tx_fixup,
18031803
};
@@ -1810,7 +1810,7 @@ static const struct driver_info at_umc2000_info = {
18101810
.link_reset = ax88179_link_reset,
18111811
.reset = ax88179_reset,
18121812
.stop = ax88179_stop,
1813-
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
1813+
.flags = FLAG_ETHER | FLAG_FRAMING_AX,
18141814
.rx_fixup = ax88179_rx_fixup,
18151815
.tx_fixup = ax88179_tx_fixup,
18161816
};
@@ -1823,7 +1823,7 @@ static const struct driver_info at_umc200_info = {
18231823
.link_reset = ax88179_link_reset,
18241824
.reset = ax88179_reset,
18251825
.stop = ax88179_stop,
1826-
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
1826+
.flags = FLAG_ETHER | FLAG_FRAMING_AX,
18271827
.rx_fixup = ax88179_rx_fixup,
18281828
.tx_fixup = ax88179_tx_fixup,
18291829
};
@@ -1836,7 +1836,7 @@ static const struct driver_info at_umc2000sp_info = {
18361836
.link_reset = ax88179_link_reset,
18371837
.reset = ax88179_reset,
18381838
.stop = ax88179_stop,
1839-
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
1839+
.flags = FLAG_ETHER | FLAG_FRAMING_AX,
18401840
.rx_fixup = ax88179_rx_fixup,
18411841
.tx_fixup = ax88179_tx_fixup,
18421842
};

0 commit comments

Comments
 (0)