Skip to content

Commit 6fc75f3

Browse files
Christoph Hellwigaxboe
authored andcommitted
block: factor out a blk_debugfs_remove helper
Split the debugfs removal from blk_unregister_queue into a helper so that the it can be reused for blk_register_queue error handling. Signed-off-by: Christoph Hellwig <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 450deb9 commit 6fc75f3

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

block/blk-sysfs.c

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -800,6 +800,19 @@ struct kobj_type blk_queue_ktype = {
800800
.release = blk_release_queue,
801801
};
802802

803+
static void blk_debugfs_remove(struct gendisk *disk)
804+
{
805+
struct request_queue *q = disk->queue;
806+
807+
mutex_lock(&q->debugfs_mutex);
808+
blk_trace_shutdown(q);
809+
debugfs_remove_recursive(q->debugfs_dir);
810+
q->debugfs_dir = NULL;
811+
q->sched_debugfs_dir = NULL;
812+
q->rqos_debugfs_dir = NULL;
813+
mutex_unlock(&q->debugfs_mutex);
814+
}
815+
803816
/**
804817
* blk_register_queue - register a block layer queue with sysfs
805818
* @disk: Disk of which the request queue should be registered with sysfs.
@@ -925,11 +938,5 @@ void blk_unregister_queue(struct gendisk *disk)
925938
kobject_del(&q->kobj);
926939
mutex_unlock(&q->sysfs_dir_lock);
927940

928-
mutex_lock(&q->debugfs_mutex);
929-
blk_trace_shutdown(q);
930-
debugfs_remove_recursive(q->debugfs_dir);
931-
q->debugfs_dir = NULL;
932-
q->sched_debugfs_dir = NULL;
933-
q->rqos_debugfs_dir = NULL;
934-
mutex_unlock(&q->debugfs_mutex);
941+
blk_debugfs_remove(disk);
935942
}

0 commit comments

Comments
 (0)