Skip to content

Commit 6f9defa

Browse files
dangowrtPaolo Abeni
authored andcommitted
net: phy: aquantia: fix applying active_low bit after reset
for_each_set_bit was used wrongly in aqr107_config_init() when iterating over LEDs. Drop misleading 'index' variable and call aqr_phy_led_active_low_set() for each set bit representing an LED which is driven by VDD instead of GND pin. Fixes: 61578f6 ("net: phy: aquantia: add support for PHY LEDs") Signed-off-by: Daniel Golle <[email protected]> Reviewed-by: Russell King (Oracle) <[email protected]> Link: https://patch.msgid.link/9b1f0cd91f4cda54c8be56b4fe780480baf4aa0f.1726580902.git.daniel@makrotopia.org Signed-off-by: Paolo Abeni <[email protected]>
1 parent d2b366c commit 6f9defa

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/net/phy/aquantia/aquantia_main.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ static int aqr107_config_init(struct phy_device *phydev)
489489
{
490490
struct aqr107_priv *priv = phydev->priv;
491491
u32 led_active_low;
492-
int ret, index = 0;
492+
int ret;
493493

494494
/* Check that the PHY interface type is compatible */
495495
if (phydev->interface != PHY_INTERFACE_MODE_SGMII &&
@@ -516,10 +516,9 @@ static int aqr107_config_init(struct phy_device *phydev)
516516

517517
/* Restore LED polarity state after reset */
518518
for_each_set_bit(led_active_low, &priv->leds_active_low, AQR_MAX_LEDS) {
519-
ret = aqr_phy_led_active_low_set(phydev, index, led_active_low);
519+
ret = aqr_phy_led_active_low_set(phydev, led_active_low, true);
520520
if (ret)
521521
return ret;
522-
index++;
523522
}
524523

525524
return 0;

0 commit comments

Comments
 (0)