Skip to content

Commit 68511b4

Browse files
roidayanSaeed Mahameed
authored andcommitted
net/mlx5e: TC, Remove redundant error logging
Remove redundant and trivial error logging when trying to offload mirred device with unsupported devices. Using OVS could hit those a lot and the errors are still logged in extack. Signed-off-by: Roi Dayan <[email protected]> Reviewed-by: Maor Dickman <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent be23511 commit 68511b4

File tree

1 file changed

+0
-8
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core/en/tc/act

1 file changed

+0
-8
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/mirred.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,10 @@ verify_uplink_forwarding(struct mlx5e_priv *priv,
4545
termination_table_raw_traffic)) {
4646
NL_SET_ERR_MSG_MOD(extack,
4747
"devices are both uplink, can't offload forwarding");
48-
pr_err("devices %s %s are both uplink, can't offload forwarding\n",
49-
priv->netdev->name, out_dev->name);
5048
return -EOPNOTSUPP;
5149
} else if (out_dev != rep_priv->netdev) {
5250
NL_SET_ERR_MSG_MOD(extack,
5351
"devices are not the same uplink, can't offload forwarding");
54-
pr_err("devices %s %s are both uplink but not the same, can't offload forwarding\n",
55-
priv->netdev->name, out_dev->name);
5652
return -EOPNOTSUPP;
5753
}
5854
return 0;
@@ -160,10 +156,6 @@ tc_act_can_offload_mirred(struct mlx5e_tc_act_parse_state *parse_state,
160156
}
161157

162158
NL_SET_ERR_MSG_MOD(extack, "devices are not on same switch HW, can't offload forwarding");
163-
netdev_warn(priv->netdev,
164-
"devices %s %s not on same switch HW, can't offload forwarding\n",
165-
netdev_name(priv->netdev),
166-
out_dev->name);
167159

168160
return false;
169161
}

0 commit comments

Comments
 (0)