Skip to content

Commit 66cf743

Browse files
roygerdavem330
authored andcommitted
xen-netback: use default TX queue size for vifs
Do not set netback interfaces (vifs) default TX queue size to the ring size. The TX queue size is not related to the ring size, and using the ring size (32) as the queue size can lead to packet drops. Note the TX side of the vif interface in the netback domain is the one receiving packets to be injected to the guest. Do not explicitly set the TX queue length to any value when creating the interface, and instead use the system default. Note that the queue length can also be adjusted at runtime. Fixes: f942dc2 ('xen network backend driver') Signed-off-by: Roger Pau Monné <[email protected]> Reviewed-by: Ross Lagerwall <[email protected]> Acked-by: Wei Liu <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1e0b72a commit 66cf743

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/net/xen-netback/interface.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@
4141
#include <asm/xen/hypercall.h>
4242
#include <xen/balloon.h>
4343

44-
#define XENVIF_QUEUE_LENGTH 32
45-
4644
/* Number of bytes allowed on the internal guest Rx queue. */
4745
#define XENVIF_RX_QUEUE_BYTES (XEN_NETIF_RX_RING_SIZE/2 * PAGE_SIZE)
4846

@@ -530,8 +528,6 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
530528
dev->features = dev->hw_features | NETIF_F_RXCSUM;
531529
dev->ethtool_ops = &xenvif_ethtool_ops;
532530

533-
dev->tx_queue_len = XENVIF_QUEUE_LENGTH;
534-
535531
dev->min_mtu = ETH_MIN_MTU;
536532
dev->max_mtu = ETH_MAX_MTU - VLAN_ETH_HLEN;
537533

0 commit comments

Comments
 (0)