Skip to content

Commit 63b1a7d

Browse files
zijun-huVudentz
authored andcommitted
Bluetooth: hci_sync: Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING
Core driver addtionally checks LMP feature bit "Erroneous Data Reporting" instead of quirk HCI_QUIRK_BROKEN_ERR_DATA_REPORTING to decide if HCI commands HCI_Read|Write_Default_Erroneous_Data_Reporting are broken, so remove this unnecessary quirk. Signed-off-by: Zijun Hu <[email protected]> Tested-by: Zijun Hu <[email protected]> Signed-off-by: Luiz Augusto von Dentz <[email protected]>
1 parent e168f69 commit 63b1a7d

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

include/net/bluetooth/hci.h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -228,17 +228,6 @@ enum {
228228
*/
229229
HCI_QUIRK_VALID_LE_STATES,
230230

231-
/* When this quirk is set, then erroneous data reporting
232-
* is ignored. This is mainly due to the fact that the HCI
233-
* Read Default Erroneous Data Reporting command is advertised,
234-
* but not supported; these controllers often reply with unknown
235-
* command and tend to lock up randomly. Needing a hard reset.
236-
*
237-
* This quirk can be set before hci_register_dev is called or
238-
* during the hdev->setup vendor callback.
239-
*/
240-
HCI_QUIRK_BROKEN_ERR_DATA_REPORTING,
241-
242231
/*
243232
* When this quirk is set, then the hci_suspend_notifier is not
244233
* registered. This is intended for devices which drop completely

net/bluetooth/hci_sync.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3865,9 +3865,6 @@ static const struct {
38653865
HCI_QUIRK_BROKEN(STORED_LINK_KEY,
38663866
"HCI Delete Stored Link Key command is advertised, "
38673867
"but not supported."),
3868-
HCI_QUIRK_BROKEN(ERR_DATA_REPORTING,
3869-
"HCI Read Default Erroneous Data Reporting command is "
3870-
"advertised, but not supported."),
38713868
HCI_QUIRK_BROKEN(READ_TRANSMIT_POWER,
38723869
"HCI Read Transmit Power Level command is advertised, "
38733870
"but not supported."),

0 commit comments

Comments
 (0)