Skip to content

Commit 61d1f54

Browse files
LorenzoBianconinbd168
authored andcommitted
wifi: mt76: move mcu_uni_event and mcu_reg_event in common code
mcu_uni_event and mcu_reg_event structs are shared between mt7921 and mt7615 drivers, so move them in connac lib. Signed-off-by: Lorenzo Bianconi <[email protected]> Signed-off-by: Felix Fietkau <[email protected]>
1 parent 878161d commit 61d1f54

File tree

5 files changed

+19
-30
lines changed

5 files changed

+19
-30
lines changed

drivers/net/wireless/mediatek/mt76/mt7615/mcu.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,16 +163,16 @@ int mt7615_mcu_parse_response(struct mt76_dev *mdev, int cmd,
163163
cmd == MCU_UNI_CMD(HIF_CTRL) ||
164164
cmd == MCU_UNI_CMD(OFFLOAD) ||
165165
cmd == MCU_UNI_CMD(SUSPEND)) {
166-
struct mt7615_mcu_uni_event *event;
166+
struct mt76_connac_mcu_uni_event *event;
167167

168168
skb_pull(skb, sizeof(*rxd));
169-
event = (struct mt7615_mcu_uni_event *)skb->data;
169+
event = (struct mt76_connac_mcu_uni_event *)skb->data;
170170
ret = le32_to_cpu(event->status);
171171
} else if (cmd == MCU_CE_QUERY(REG_READ)) {
172-
struct mt7615_mcu_reg_event *event;
172+
struct mt76_connac_mcu_reg_event *event;
173173

174174
skb_pull(skb, sizeof(*rxd));
175-
event = (struct mt7615_mcu_reg_event *)skb->data;
175+
event = (struct mt76_connac_mcu_reg_event *)skb->data;
176176
ret = (int)le32_to_cpu(event->val);
177177
}
178178

drivers/net/wireless/mediatek/mt76/mt7615/mcu.h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -206,17 +206,6 @@ enum {
206206
MCU_ATE_SET_TX_POWER_CONTROL = 0x15,
207207
};
208208

209-
struct mt7615_mcu_uni_event {
210-
u8 cid;
211-
u8 pad[3];
212-
__le32 status; /* 0: success, others: fail */
213-
} __packed;
214-
215-
struct mt7615_mcu_reg_event {
216-
__le32 reg;
217-
__le32 val;
218-
} __packed;
219-
220209
struct mt7615_roc_tlv {
221210
u8 bss_idx;
222211
u8 token;

drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1690,6 +1690,17 @@ struct mt76_connac_config {
16901690
u8 data[320];
16911691
} __packed;
16921692

1693+
struct mt76_connac_mcu_uni_event {
1694+
u8 cid;
1695+
u8 pad[3];
1696+
__le32 status; /* 0: success, others: fail */
1697+
} __packed;
1698+
1699+
struct mt76_connac_mcu_reg_event {
1700+
__le32 reg;
1701+
__le32 val;
1702+
} __packed;
1703+
16931704
static inline enum mcu_cipher_type
16941705
mt76_connac_mcu_get_cipher(int cipher)
16951706
{

drivers/net/wireless/mediatek/mt76/mt7921/mcu.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,19 +67,19 @@ int mt7921_mcu_parse_response(struct mt76_dev *mdev, int cmd,
6767
cmd == MCU_UNI_CMD(HIF_CTRL) ||
6868
cmd == MCU_UNI_CMD(OFFLOAD) ||
6969
cmd == MCU_UNI_CMD(SUSPEND)) {
70-
struct mt7921_mcu_uni_event *event;
70+
struct mt76_connac_mcu_uni_event *event;
7171

7272
skb_pull(skb, sizeof(*rxd));
73-
event = (struct mt7921_mcu_uni_event *)skb->data;
73+
event = (struct mt76_connac_mcu_uni_event *)skb->data;
7474
ret = le32_to_cpu(event->status);
7575
/* skip invalid event */
7676
if (mcu_cmd != event->cid)
7777
ret = -EAGAIN;
7878
} else if (cmd == MCU_CE_QUERY(REG_READ)) {
79-
struct mt7921_mcu_reg_event *event;
79+
struct mt76_connac_mcu_reg_event *event;
8080

8181
skb_pull(skb, sizeof(*rxd));
82-
event = (struct mt7921_mcu_reg_event *)skb->data;
82+
event = (struct mt76_connac_mcu_reg_event *)skb->data;
8383
ret = (int)le32_to_cpu(event->val);
8484
} else {
8585
skb_pull(skb, sizeof(struct mt76_connac2_mcu_rxd));

drivers/net/wireless/mediatek/mt76/mt7921/mcu.h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -50,22 +50,11 @@ struct mt7921_mcu_eeprom_info {
5050
#define MT_RA_RATE_DCM_EN BIT(4)
5151
#define MT_RA_RATE_BW GENMASK(14, 13)
5252

53-
struct mt7921_mcu_uni_event {
54-
u8 cid;
55-
u8 pad[3];
56-
__le32 status; /* 0: success, others: fail */
57-
} __packed;
58-
5953
enum {
6054
MT_EBF = BIT(0), /* explicit beamforming */
6155
MT_IBF = BIT(1) /* implicit beamforming */
6256
};
6357

64-
struct mt7921_mcu_reg_event {
65-
__le32 reg;
66-
__le32 val;
67-
} __packed;
68-
6958
struct mt7921_mcu_ant_id_config {
7059
u8 ant_id[4];
7160
} __packed;

0 commit comments

Comments
 (0)