Skip to content

Commit 5eb1422

Browse files
committed
s390/ipl: Fix incorrect initialization of nvme dump block
JIRA: https://issues.redhat.com/browse/RHEL-86670 commit 7faacae Author: Alexander Egorenkov <[email protected]> Date: Fri May 10 12:41:26 2024 +0200 s390/ipl: Fix incorrect initialization of nvme dump block Initialize the correct fields of the nvme dump block. This bug had not been detected before because first, the fcp and nvme fields of struct ipl_parameter_block are part of the same union and, therefore, overlap in memory and second, they are identical in structure and size. Fixes: d70e38c ("s390: nvme dump support") Reviewed-by: Heiko Carstens <[email protected]> Signed-off-by: Alexander Egorenkov <[email protected]> Signed-off-by: Alexander Gordeev <[email protected]> Signed-off-by: Thomas Huth <[email protected]>
1 parent d5c938c commit 5eb1422

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

arch/s390/kernel/ipl.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1864,9 +1864,9 @@ static int __init dump_nvme_init(void)
18641864
}
18651865
dump_block_nvme->hdr.len = IPL_BP_NVME_LEN;
18661866
dump_block_nvme->hdr.version = IPL_PARM_BLOCK_VERSION;
1867-
dump_block_nvme->fcp.len = IPL_BP0_NVME_LEN;
1868-
dump_block_nvme->fcp.pbt = IPL_PBT_NVME;
1869-
dump_block_nvme->fcp.opt = IPL_PB0_NVME_OPT_DUMP;
1867+
dump_block_nvme->nvme.len = IPL_BP0_NVME_LEN;
1868+
dump_block_nvme->nvme.pbt = IPL_PBT_NVME;
1869+
dump_block_nvme->nvme.opt = IPL_PB0_NVME_OPT_DUMP;
18701870
dump_capabilities |= DUMP_TYPE_NVME;
18711871
return 0;
18721872
}

0 commit comments

Comments
 (0)