Skip to content

Commit 5d68924

Browse files
aagittorvalds
authored andcommitted
thp: select CONFIG_COMPACTION if TRANSPARENT_HUGEPAGE enabled
With transparent hugepage support we need compaction for the "defrag" sysfs controls to be effective. At the moment THP hangs the system if COMPACTION isn't selected, as without COMPACTION lumpy reclaim wouldn't be entirely disabled. So at the moment it's not orthogonal. When lumpy will be removed from the VM I can remove the select COMPACTION in theory, but then 99% of THP users would be still doing a mistake in disabling compaction, even if the mistake won't return in fatal runtime but just slightly degraded performance. So from a theoretical standpoing forcing the below select is not needed (the dependency isn't strict nor at compile time nor at runtime) but from a practical standpoint it is safer. If anybody really wants THP to run without compaction, it'd be such a weird setup that editing the Kconfig file to allow it will be surely not a problem. Signed-off-by: Andrea Arcangeli <[email protected]> Acked-by: Mel Gorman <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 13ece88 commit 5d68924

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

mm/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,7 @@ config NOMMU_INITIAL_TRIM_EXCESS
305305
config TRANSPARENT_HUGEPAGE
306306
bool "Transparent Hugepage Support"
307307
depends on X86 && MMU
308+
select COMPACTION
308309
help
309310
Transparent Hugepages allows the kernel to use huge pages and
310311
huge tlb transparently to the applications whenever possible.

0 commit comments

Comments
 (0)