devlink: extend devlink_param *set pointer

halfboy93 · anguy11 · commit 5625ca5640ca · 2024-04-22T13:05:19.000-07:00
Extend devlink_param *set function pointer to take extack as a param.
Sometimes it is needed to pass information to the end user from set
function. It is more proper to use for that netlink instead of passing
message to dmesg.

Reviewed-by: Jiri Pirko &lt;jiri@nvidia.com&gt;
Reviewed-by: Przemek Kitszel &lt;przemyslaw.kitszel@intel.com&gt;
Signed-off-by: Mateusz Polchlopek &lt;mateusz.polchlopek@intel.com&gt;
Signed-off-by: Tony Nguyen &lt;anthony.l.nguyen@intel.com&gt;
diff --git a/drivers/crypto/marvell/octeontx2/otx2_cpt_devlink.c b/drivers/crypto/marvell/octeontx2/otx2_cpt_devlink.c
@@ -4,7 +4,8 @@
 #include "otx2_cpt_devlink.h"
 
 static int otx2_cpt_dl_egrp_create(struct devlink *dl, u32 id,
-				   struct devlink_param_gset_ctx *ctx)
+				   struct devlink_param_gset_ctx *ctx,
+				   struct netlink_ext_ack *extack)
 {
 	struct otx2_cpt_devlink *cpt_dl = devlink_priv(dl);
 	struct otx2_cptpf_dev *cptpf = cpt_dl->cptpf;
@@ -13,7 +14,8 @@ static int otx2_cpt_dl_egrp_create(struct devlink *dl, u32 id,
 }
 
 static int otx2_cpt_dl_egrp_delete(struct devlink *dl, u32 id,
-				   struct devlink_param_gset_ctx *ctx)
+				   struct devlink_param_gset_ctx *ctx,
+				   struct netlink_ext_ack *extack)
 {
 	struct otx2_cpt_devlink *cpt_dl = devlink_priv(dl);
 	struct otx2_cptpf_dev *cptpf = cpt_dl->cptpf;
@@ -45,7 +47,8 @@ static int otx2_cpt_dl_t106_mode_get(struct devlink *dl, u32 id,
 }
 
 static int otx2_cpt_dl_t106_mode_set(struct devlink *dl, u32 id,
-				     struct devlink_param_gset_ctx *ctx)
+				     struct devlink_param_gset_ctx *ctx,
+				     struct netlink_ext_ack *extack)
 {
 	struct otx2_cpt_devlink *cpt_dl = devlink_priv(dl);
 	struct otx2_cptpf_dev *cptpf = cpt_dl->cptpf;
diff --git a/drivers/net/ethernet/amd/pds_core/core.h b/drivers/net/ethernet/amd/pds_core/core.h
@@ -256,7 +256,8 @@ int pdsc_dl_flash_update(struct devlink *dl,
 int pdsc_dl_enable_get(struct devlink *dl, u32 id,
 		       struct devlink_param_gset_ctx *ctx);
 int pdsc_dl_enable_set(struct devlink *dl, u32 id,
-		       struct devlink_param_gset_ctx *ctx);
+		       struct devlink_param_gset_ctx *ctx,
+		       struct netlink_ext_ack *extack);
 int pdsc_dl_enable_validate(struct devlink *dl, u32 id,
 			    union devlink_param_value val,
 			    struct netlink_ext_ack *extack);
diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethernet/amd/pds_core/devlink.c
@@ -37,7 +37,8 @@ int pdsc_dl_enable_get(struct devlink *dl, u32 id,
 }
 
 int pdsc_dl_enable_set(struct devlink *dl, u32 id,
-		       struct devlink_param_gset_ctx *ctx)
+		       struct devlink_param_gset_ctx *ctx,
+		       struct netlink_ext_ack *extack)
 {
 	struct pdsc *pdsc = devlink_priv(dl);
 	struct pdsc_viftype *vt_entry;
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -1096,7 +1096,8 @@ static int bnxt_dl_nvm_param_get(struct devlink *dl, u32 id,
 }
 
 static int bnxt_dl_nvm_param_set(struct devlink *dl, u32 id,
-				 struct devlink_param_gset_ctx *ctx)
+				 struct devlink_param_gset_ctx *ctx,
+				 struct netlink_ext_ack *extack)
 {
 	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
 	struct hwrm_nvm_set_variable_input *req;
@@ -1145,7 +1146,8 @@ static int bnxt_remote_dev_reset_get(struct devlink *dl, u32 id,
 }
 
 static int bnxt_remote_dev_reset_set(struct devlink *dl, u32 id,
-				     struct devlink_param_gset_ctx *ctx)
+				     struct devlink_param_gset_ctx *ctx,
+				     struct netlink_ext_ack *extack)
 {
 	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
 	int rc;
diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c b/drivers/net/ethernet/intel/ice/devlink/devlink.c
@@ -1144,9 +1144,9 @@ ice_devlink_enable_roce_get(struct devlink *devlink, u32 id,
 	return 0;
 }
 
-static int
-ice_devlink_enable_roce_set(struct devlink *devlink, u32 id,
-			    struct devlink_param_gset_ctx *ctx)
+static int ice_devlink_enable_roce_set(struct devlink *devlink, u32 id,
+				       struct devlink_param_gset_ctx *ctx,
+				       struct netlink_ext_ack *extack)
 {
 	struct ice_pf *pf = devlink_priv(devlink);
 	bool roce_ena = ctx->val.vbool;
@@ -1195,9 +1195,9 @@ ice_devlink_enable_iw_get(struct devlink *devlink, u32 id,
 	return 0;
 }
 
-static int
-ice_devlink_enable_iw_set(struct devlink *devlink, u32 id,
-			  struct devlink_param_gset_ctx *ctx)
+static int ice_devlink_enable_iw_set(struct devlink *devlink, u32 id,
+				     struct devlink_param_gset_ctx *ctx,
+				     struct netlink_ext_ack *extack)
 {
 	struct ice_pf *pf = devlink_priv(devlink);
 	bool iw_ena = ctx->val.vbool;
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c
@@ -1202,7 +1202,8 @@ static int rvu_af_dl_dwrr_mtu_validate(struct devlink *devlink, u32 id,
 }
 
 static int rvu_af_dl_dwrr_mtu_set(struct devlink *devlink, u32 id,
-				  struct devlink_param_gset_ctx *ctx)
+				  struct devlink_param_gset_ctx *ctx,
+				  struct netlink_ext_ack *extack)
 {
 	struct rvu_devlink *rvu_dl = devlink_priv(devlink);
 	struct rvu *rvu = rvu_dl->rvu;
@@ -1256,7 +1257,8 @@ static int rvu_af_npc_exact_feature_get(struct devlink *devlink, u32 id,
 }
 
 static int rvu_af_npc_exact_feature_disable(struct devlink *devlink, u32 id,
-					    struct devlink_param_gset_ctx *ctx)
+					    struct devlink_param_gset_ctx *ctx,
+					    struct netlink_ext_ack *extack)
 {
 	struct rvu_devlink *rvu_dl = devlink_priv(devlink);
 	struct rvu *rvu = rvu_dl->rvu;
@@ -1310,7 +1312,8 @@ static int rvu_af_dl_npc_mcam_high_zone_percent_get(struct devlink *devlink, u32
 }
 
 static int rvu_af_dl_npc_mcam_high_zone_percent_set(struct devlink *devlink, u32 id,
-						    struct devlink_param_gset_ctx *ctx)
+						    struct devlink_param_gset_ctx *ctx,
+						    struct netlink_ext_ack *extack)
 {
 	struct rvu_devlink *rvu_dl = devlink_priv(devlink);
 	struct rvu *rvu = rvu_dl->rvu;
@@ -1367,7 +1370,8 @@ static int rvu_af_dl_nix_maxlf_get(struct devlink *devlink, u32 id,
 }
 
 static int rvu_af_dl_nix_maxlf_set(struct devlink *devlink, u32 id,
-				   struct devlink_param_gset_ctx *ctx)
+				   struct devlink_param_gset_ctx *ctx,
+				   struct netlink_ext_ack *extack)
 {
 	struct rvu_devlink *rvu_dl = devlink_priv(devlink);
 	struct rvu *rvu = rvu_dl->rvu;
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c
@@ -32,7 +32,8 @@ static int otx2_dl_mcam_count_validate(struct devlink *devlink, u32 id,
 }
 
 static int otx2_dl_mcam_count_set(struct devlink *devlink, u32 id,
-				  struct devlink_param_gset_ctx *ctx)
+				  struct devlink_param_gset_ctx *ctx,
+				  struct netlink_ext_ack *extack)
 {
 	struct otx2_devlink *otx2_dl = devlink_priv(devlink);
 	struct otx2_nic *pfvf = otx2_dl->pfvf;
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -185,7 +185,8 @@ static int mlx4_devlink_ierr_reset_get(struct devlink *devlink, u32 id,
 }
 
 static int mlx4_devlink_ierr_reset_set(struct devlink *devlink, u32 id,
-				       struct devlink_param_gset_ctx *ctx)
+				       struct devlink_param_gset_ctx *ctx,
+				       struct netlink_ext_ack *extack)
 {
 	mlx4_internal_err_reset = ctx->val.vbool;
 	return 0;
@@ -202,7 +203,8 @@ static int mlx4_devlink_crdump_snapshot_get(struct devlink *devlink, u32 id,
 }
 
 static int mlx4_devlink_crdump_snapshot_set(struct devlink *devlink, u32 id,
-					    struct devlink_param_gset_ctx *ctx)
+					    struct devlink_param_gset_ctx *ctx,
+					    struct netlink_ext_ack *extack)
 {
 	struct mlx4_priv *priv = devlink_priv(devlink);
 	struct mlx4_dev *dev = &priv->dev;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
@@ -1805,7 +1805,8 @@ static int mlx5_esw_vports_init(struct mlx5_eswitch *esw)
 }
 
 static int mlx5_devlink_esw_multiport_set(struct devlink *devlink, u32 id,
-					  struct devlink_param_gset_ctx *ctx)
+					  struct devlink_param_gset_ctx *ctx,
+					  struct netlink_ext_ack *extack)
 {
 	struct mlx5_core_dev *dev = devlink_priv(devlink);
 
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
@@ -2413,7 +2413,8 @@ static int esw_offloads_init_reps(struct mlx5_eswitch *esw)
 }
 
 static int esw_port_metadata_set(struct devlink *devlink, u32 id,
-				 struct devlink_param_gset_ctx *ctx)
+				 struct devlink_param_gset_ctx *ctx,
+				 struct netlink_ext_ack *extack)
 {
 	struct mlx5_core_dev *dev = devlink_priv(devlink);
 	struct mlx5_eswitch *esw = dev->priv.eswitch;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
@@ -3332,7 +3332,8 @@ static int mlx5_fs_mode_validate(struct devlink *devlink, u32 id,
 }
 
 static int mlx5_fs_mode_set(struct devlink *devlink, u32 id,
-			    struct devlink_param_gset_ctx *ctx)
+			    struct devlink_param_gset_ctx *ctx,
+			    struct netlink_ext_ack *extack)
 {
 	struct mlx5_core_dev *dev = devlink_priv(devlink);
 	enum mlx5_flow_steering_mode mode;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c b/drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c
@@ -52,7 +52,8 @@ static void mlx5_set_fw_rst_ack(struct mlx5_core_dev *dev)
 }
 
 static int mlx5_fw_reset_enable_remote_dev_reset_set(struct devlink *devlink, u32 id,
-						     struct devlink_param_gset_ctx *ctx)
+						     struct devlink_param_gset_ctx *ctx,
+						     struct netlink_ext_ack *extack)
 {
 	struct mlx5_core_dev *dev = devlink_priv(devlink);
 	struct mlx5_fw_reset *fw_reset;
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c
@@ -1465,7 +1465,8 @@ mlxsw_sp_acl_tcam_region_rehash_intrvl_get(struct devlink *devlink, u32 id,
 
 static int
 mlxsw_sp_acl_tcam_region_rehash_intrvl_set(struct devlink *devlink, u32 id,
-					   struct devlink_param_gset_ctx *ctx)
+					   struct devlink_param_gset_ctx *ctx,
+					   struct netlink_ext_ack *extack)
 {
 	struct mlxsw_core *mlxsw_core = devlink_priv(devlink);
 	struct mlxsw_sp_acl_tcam_vregion *vregion;
diff --git a/drivers/net/ethernet/netronome/nfp/devlink_param.c b/drivers/net/ethernet/netronome/nfp/devlink_param.c
@@ -132,7 +132,8 @@ nfp_devlink_param_u8_get(struct devlink *devlink, u32 id,
 
 static int
 nfp_devlink_param_u8_set(struct devlink *devlink, u32 id,
-			 struct devlink_param_gset_ctx *ctx)
+			 struct devlink_param_gset_ctx *ctx,
+			 struct netlink_ext_ack *extack)
 {
 	const struct nfp_devlink_param_u8_arg *arg;
 	struct nfp_pf *pf = devlink_priv(devlink);
diff --git a/drivers/net/ethernet/qlogic/qed/qed_devlink.c b/drivers/net/ethernet/qlogic/qed/qed_devlink.c
@@ -132,7 +132,8 @@ static int qed_dl_param_get(struct devlink *dl, u32 id,
 }
 
 static int qed_dl_param_set(struct devlink *dl, u32 id,
-			    struct devlink_param_gset_ctx *ctx)
+			    struct devlink_param_gset_ctx *ctx,
+			    struct netlink_ext_ack *extack)
 {
 	struct qed_devlink *qed_dl = devlink_priv(dl);
 	struct qed_dev *cdev;
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -3061,7 +3061,8 @@ static void am65_cpsw_init_port_switch_ale(struct am65_cpsw_port *port)
 }
 
 static int am65_cpsw_dl_switch_mode_set(struct devlink *dl, u32 id,
-					struct devlink_param_gset_ctx *ctx)
+					struct devlink_param_gset_ctx *ctx,
+					struct netlink_ext_ack *extack)
 {
 	struct am65_cpsw_devlink *dl_priv = devlink_priv(dl);
 	struct am65_cpsw_common *cpsw = dl_priv->common;
diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c
@@ -1625,7 +1625,8 @@ static int cpsw_dl_switch_mode_get(struct devlink *dl, u32 id,
 }
 
 static int cpsw_dl_switch_mode_set(struct devlink *dl, u32 id,
-				   struct devlink_param_gset_ctx *ctx)
+				   struct devlink_param_gset_ctx *ctx,
+				   struct netlink_ext_ack *extack)
 {
 	struct cpsw_devlink *dl_priv = devlink_priv(dl);
 	struct cpsw_common *cpsw = dl_priv->cpsw;
@@ -1762,7 +1763,8 @@ static int cpsw_dl_ale_ctrl_get(struct devlink *dl, u32 id,
 }
 
 static int cpsw_dl_ale_ctrl_set(struct devlink *dl, u32 id,
-				struct devlink_param_gset_ctx *ctx)
+				struct devlink_param_gset_ctx *ctx,
+				struct netlink_ext_ack *extack)
 {
 	struct cpsw_devlink *dl_priv = devlink_priv(dl);
 	struct cpsw_common *cpsw = dl_priv->cpsw;
diff --git a/drivers/net/wwan/iosm/iosm_ipc_devlink.c b/drivers/net/wwan/iosm/iosm_ipc_devlink.c
@@ -33,7 +33,8 @@ static int ipc_devlink_get_param(struct devlink *dl, u32 id,
 
 /* Set the param values for the specific param ID's */
 static int ipc_devlink_set_param(struct devlink *dl, u32 id,
-				 struct devlink_param_gset_ctx *ctx)
+				 struct devlink_param_gset_ctx *ctx,
+				 struct netlink_ext_ack *extack)
 {
 	struct iosm_devlink *ipc_devlink = devlink_priv(dl);
 
diff --git a/include/net/devlink.h b/include/net/devlink.h
@@ -483,7 +483,8 @@ struct devlink_param {
 	int (*get)(struct devlink *devlink, u32 id,
 		   struct devlink_param_gset_ctx *ctx);
 	int (*set)(struct devlink *devlink, u32 id,
-		   struct devlink_param_gset_ctx *ctx);
+		   struct devlink_param_gset_ctx *ctx,
+		   struct netlink_ext_ack *extack);
 	int (*validate)(struct devlink *devlink, u32 id,
 			union devlink_param_value val,
 			struct netlink_ext_ack *extack);
diff --git a/include/net/dsa.h b/include/net/dsa.h
@@ -1258,7 +1258,8 @@ struct dsa_switch_ops {
 int dsa_devlink_param_get(struct devlink *dl, u32 id,
 			  struct devlink_param_gset_ctx *ctx);
 int dsa_devlink_param_set(struct devlink *dl, u32 id,
-			  struct devlink_param_gset_ctx *ctx);
+			  struct devlink_param_gset_ctx *ctx,
+			  struct netlink_ext_ack *extack);
 int dsa_devlink_params_register(struct dsa_switch *ds,
 				const struct devlink_param *params,
 				size_t params_count);
diff --git a/net/devlink/param.c b/net/devlink/param.c
@@ -158,11 +158,12 @@ static int devlink_param_get(struct devlink *devlink,
 
 static int devlink_param_set(struct devlink *devlink,
 			     const struct devlink_param *param,
-			     struct devlink_param_gset_ctx *ctx)
+			     struct devlink_param_gset_ctx *ctx,
+			     struct netlink_ext_ack *extack)
 {
 	if (!param->set)
 		return -EOPNOTSUPP;
-	return param->set(devlink, param->id, ctx);
+	return param->set(devlink, param->id, ctx, extack);
 }
 
 static int
@@ -571,7 +572,7 @@ static int __devlink_nl_cmd_param_set_doit(struct devlink *devlink,
 			return -EOPNOTSUPP;
 		ctx.val = value;
 		ctx.cmode = cmode;
-		err = devlink_param_set(devlink, param, &ctx);
+		err = devlink_param_set(devlink, param, &ctx, info->extack);
 		if (err)
 			return err;
 	}
diff --git a/net/dsa/devlink.c b/net/dsa/devlink.c
@@ -194,7 +194,8 @@ int dsa_devlink_param_get(struct devlink *dl, u32 id,
 EXPORT_SYMBOL_GPL(dsa_devlink_param_get);
 
 int dsa_devlink_param_set(struct devlink *dl, u32 id,
-			  struct devlink_param_gset_ctx *ctx)
+			  struct devlink_param_gset_ctx *ctx,
+			  struct netlink_ext_ack *extack)
 {
 	struct dsa_switch *ds = dsa_devlink_to_ds(dl);
 

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,8 @@`
`4`	`4`	`#include "otx2_cpt_devlink.h"`
`5`	`5`
`6`	`6`	`static int otx2_cpt_dl_egrp_create(struct devlink *dl, u32 id,`
`7`		`- struct devlink_param_gset_ctx *ctx)`
	`7`	`+ struct devlink_param_gset_ctx *ctx,`
	`8`	`+ struct netlink_ext_ack *extack)`
`8`	`9`	`{`
`9`	`10`	`struct otx2_cpt_devlink *cpt_dl = devlink_priv(dl);`
`10`	`11`	`struct otx2_cptpf_dev *cptpf = cpt_dl->cptpf;`
`@@ -13,7 +14,8 @@ static int otx2_cpt_dl_egrp_create(struct devlink *dl, u32 id,`
`13`	`14`	`}`
`14`	`15`
`15`	`16`	`static int otx2_cpt_dl_egrp_delete(struct devlink *dl, u32 id,`
`16`		`- struct devlink_param_gset_ctx *ctx)`
	`17`	`+ struct devlink_param_gset_ctx *ctx,`
	`18`	`+ struct netlink_ext_ack *extack)`
`17`	`19`	`{`
`18`	`20`	`struct otx2_cpt_devlink *cpt_dl = devlink_priv(dl);`
`19`	`21`	`struct otx2_cptpf_dev *cptpf = cpt_dl->cptpf;`
`@@ -45,7 +47,8 @@ static int otx2_cpt_dl_t106_mode_get(struct devlink *dl, u32 id,`
`45`	`47`	`}`
`46`	`48`
`47`	`49`	`static int otx2_cpt_dl_t106_mode_set(struct devlink *dl, u32 id,`
`48`		`- struct devlink_param_gset_ctx *ctx)`
	`50`	`+ struct devlink_param_gset_ctx *ctx,`
	`51`	`+ struct netlink_ext_ack *extack)`
`49`	`52`	`{`
`50`	`53`	`struct otx2_cpt_devlink *cpt_dl = devlink_priv(dl);`
`51`	`54`	`struct otx2_cptpf_dev *cptpf = cpt_dl->cptpf;`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,8 @@ int pdsc_dl_enable_get(struct devlink *dl, u32 id,`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`int pdsc_dl_enable_set(struct devlink *dl, u32 id,`
`40`		`- struct devlink_param_gset_ctx *ctx)`
	`40`	`+ struct devlink_param_gset_ctx *ctx,`
	`41`	`+ struct netlink_ext_ack *extack)`
`41`	`42`	`{`
`42`	`43`	`struct pdsc *pdsc = devlink_priv(dl);`
`43`	`44`	`struct pdsc_viftype *vt_entry;`
Original file line number	Diff line number	Diff line change
`@@ -1096,7 +1096,8 @@ static int bnxt_dl_nvm_param_get(struct devlink *dl, u32 id,`
`1096`	`1096`	`}`
`1097`	`1097`
`1098`	`1098`	`static int bnxt_dl_nvm_param_set(struct devlink *dl, u32 id,`
`1099`		`- struct devlink_param_gset_ctx *ctx)`
	`1099`	`+ struct devlink_param_gset_ctx *ctx,`
	`1100`	`+ struct netlink_ext_ack *extack)`
`1100`	`1101`	`{`
`1101`	`1102`	`struct bnxt *bp = bnxt_get_bp_from_dl(dl);`
`1102`	`1103`	`struct hwrm_nvm_set_variable_input *req;`
`@@ -1145,7 +1146,8 @@ static int bnxt_remote_dev_reset_get(struct devlink *dl, u32 id,`
`1145`	`1146`	`}`
`1146`	`1147`
`1147`	`1148`	`static int bnxt_remote_dev_reset_set(struct devlink *dl, u32 id,`
`1148`		`- struct devlink_param_gset_ctx *ctx)`
	`1149`	`+ struct devlink_param_gset_ctx *ctx,`
	`1150`	`+ struct netlink_ext_ack *extack)`
`1149`	`1151`	`{`
`1150`	`1152`	`struct bnxt *bp = bnxt_get_bp_from_dl(dl);`
`1151`	`1153`	`int rc;`
Original file line number	Diff line number	Diff line change
`@@ -1144,9 +1144,9 @@ ice_devlink_enable_roce_get(struct devlink *devlink, u32 id,`
`1144`	`1144`	`return 0;`
`1145`	`1145`	`}`
`1146`	`1146`
`1147`		`-static int`
`1148`		`-ice_devlink_enable_roce_set(struct devlink *devlink, u32 id,`
`1149`		`- struct devlink_param_gset_ctx *ctx)`
	`1147`	`+static int ice_devlink_enable_roce_set(struct devlink *devlink, u32 id,`
	`1148`	`+ struct devlink_param_gset_ctx *ctx,`
	`1149`	`+ struct netlink_ext_ack *extack)`
`1150`	`1150`	`{`
`1151`	`1151`	`struct ice_pf *pf = devlink_priv(devlink);`
`1152`	`1152`	`bool roce_ena = ctx->val.vbool;`
`@@ -1195,9 +1195,9 @@ ice_devlink_enable_iw_get(struct devlink *devlink, u32 id,`
`1195`	`1195`	`return 0;`
`1196`	`1196`	`}`
`1197`	`1197`
`1198`		`-static int`
`1199`		`-ice_devlink_enable_iw_set(struct devlink *devlink, u32 id,`
`1200`		`- struct devlink_param_gset_ctx *ctx)`
	`1198`	`+static int ice_devlink_enable_iw_set(struct devlink *devlink, u32 id,`
	`1199`	`+ struct devlink_param_gset_ctx *ctx,`
	`1200`	`+ struct netlink_ext_ack *extack)`
`1201`	`1201`	`{`
`1202`	`1202`	`struct ice_pf *pf = devlink_priv(devlink);`
`1203`	`1203`	`bool iw_ena = ctx->val.vbool;`
Original file line number	Diff line number	Diff line change
`@@ -1202,7 +1202,8 @@ static int rvu_af_dl_dwrr_mtu_validate(struct devlink *devlink, u32 id,`
`1202`	`1202`	`}`
`1203`	`1203`
`1204`	`1204`	`static int rvu_af_dl_dwrr_mtu_set(struct devlink *devlink, u32 id,`
`1205`		`- struct devlink_param_gset_ctx *ctx)`
	`1205`	`+ struct devlink_param_gset_ctx *ctx,`
	`1206`	`+ struct netlink_ext_ack *extack)`
`1206`	`1207`	`{`
`1207`	`1208`	`struct rvu_devlink *rvu_dl = devlink_priv(devlink);`
`1208`	`1209`	`struct rvu *rvu = rvu_dl->rvu;`
`@@ -1256,7 +1257,8 @@ static int rvu_af_npc_exact_feature_get(struct devlink *devlink, u32 id,`
`1256`	`1257`	`}`
`1257`	`1258`
`1258`	`1259`	`static int rvu_af_npc_exact_feature_disable(struct devlink *devlink, u32 id,`
`1259`		`- struct devlink_param_gset_ctx *ctx)`
	`1260`	`+ struct devlink_param_gset_ctx *ctx,`
	`1261`	`+ struct netlink_ext_ack *extack)`
`1260`	`1262`	`{`
`1261`	`1263`	`struct rvu_devlink *rvu_dl = devlink_priv(devlink);`
`1262`	`1264`	`struct rvu *rvu = rvu_dl->rvu;`
`@@ -1310,7 +1312,8 @@ static int rvu_af_dl_npc_mcam_high_zone_percent_get(struct devlink *devlink, u32`
`1310`	`1312`	`}`
`1311`	`1313`
`1312`	`1314`	`static int rvu_af_dl_npc_mcam_high_zone_percent_set(struct devlink *devlink, u32 id,`
`1313`		`- struct devlink_param_gset_ctx *ctx)`
	`1315`	`+ struct devlink_param_gset_ctx *ctx,`
	`1316`	`+ struct netlink_ext_ack *extack)`
`1314`	`1317`	`{`
`1315`	`1318`	`struct rvu_devlink *rvu_dl = devlink_priv(devlink);`
`1316`	`1319`	`struct rvu *rvu = rvu_dl->rvu;`
`@@ -1367,7 +1370,8 @@ static int rvu_af_dl_nix_maxlf_get(struct devlink *devlink, u32 id,`
`1367`	`1370`	`}`
`1368`	`1371`
`1369`	`1372`	`static int rvu_af_dl_nix_maxlf_set(struct devlink *devlink, u32 id,`
`1370`		`- struct devlink_param_gset_ctx *ctx)`
	`1373`	`+ struct devlink_param_gset_ctx *ctx,`
	`1374`	`+ struct netlink_ext_ack *extack)`
`1371`	`1375`	`{`
`1372`	`1376`	`struct rvu_devlink *rvu_dl = devlink_priv(devlink);`
`1373`	`1377`	`struct rvu *rvu = rvu_dl->rvu;`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,8 @@ static int otx2_dl_mcam_count_validate(struct devlink *devlink, u32 id,`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`static int otx2_dl_mcam_count_set(struct devlink *devlink, u32 id,`
`35`		`- struct devlink_param_gset_ctx *ctx)`
	`35`	`+ struct devlink_param_gset_ctx *ctx,`
	`36`	`+ struct netlink_ext_ack *extack)`
`36`	`37`	`{`
`37`	`38`	`struct otx2_devlink *otx2_dl = devlink_priv(devlink);`
`38`	`39`	`struct otx2_nic *pfvf = otx2_dl->pfvf;`
Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,8 @@ static int mlx4_devlink_ierr_reset_get(struct devlink *devlink, u32 id,`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`static int mlx4_devlink_ierr_reset_set(struct devlink *devlink, u32 id,`
`188`		`- struct devlink_param_gset_ctx *ctx)`
	`188`	`+ struct devlink_param_gset_ctx *ctx,`
	`189`	`+ struct netlink_ext_ack *extack)`
`189`	`190`	`{`
`190`	`191`	`mlx4_internal_err_reset = ctx->val.vbool;`
`191`	`192`	`return 0;`
`@@ -202,7 +203,8 @@ static int mlx4_devlink_crdump_snapshot_get(struct devlink *devlink, u32 id,`
`202`	`203`	`}`
`203`	`204`
`204`	`205`	`static int mlx4_devlink_crdump_snapshot_set(struct devlink *devlink, u32 id,`
`205`		`- struct devlink_param_gset_ctx *ctx)`
	`206`	`+ struct devlink_param_gset_ctx *ctx,`
	`207`	`+ struct netlink_ext_ack *extack)`
`206`	`208`	`{`
`207`	`209`	`struct mlx4_priv *priv = devlink_priv(devlink);`
`208`	`210`	`struct mlx4_dev *dev = &priv->dev;`
Original file line number	Diff line number	Diff line change
`@@ -1805,7 +1805,8 @@ static int mlx5_esw_vports_init(struct mlx5_eswitch *esw)`
`1805`	`1805`	`}`
`1806`	`1806`
`1807`	`1807`	`static int mlx5_devlink_esw_multiport_set(struct devlink *devlink, u32 id,`
`1808`		`- struct devlink_param_gset_ctx *ctx)`
	`1808`	`+ struct devlink_param_gset_ctx *ctx,`
	`1809`	`+ struct netlink_ext_ack *extack)`
`1809`	`1810`	`{`
`1810`	`1811`	`struct mlx5_core_dev *dev = devlink_priv(devlink);`
`1811`	`1812`
Original file line number	Diff line number	Diff line change
`@@ -2413,7 +2413,8 @@ static int esw_offloads_init_reps(struct mlx5_eswitch *esw)`
`2413`	`2413`	`}`
`2414`	`2414`
`2415`	`2415`	`static int esw_port_metadata_set(struct devlink *devlink, u32 id,`
`2416`		`- struct devlink_param_gset_ctx *ctx)`
	`2416`	`+ struct devlink_param_gset_ctx *ctx,`
	`2417`	`+ struct netlink_ext_ack *extack)`
`2417`	`2418`	`{`
`2418`	`2419`	`struct mlx5_core_dev *dev = devlink_priv(devlink);`
`2419`	`2420`	`struct mlx5_eswitch *esw = dev->priv.eswitch;`