Skip to content

Commit 5036d26

Browse files
hvilleneuvedoogregkh
authored andcommitted
serial: sc16is7xx: remove useless enable of enhanced features
commit 1c05bf6 upstream. Commit 43c51bb ("sc16is7xx: make sure device is in suspend once probed") permanently enabled access to the enhanced features in sc16is7xx_probe(), and it is never disabled after that. Therefore, remove re-enable of enhanced features in sc16is7xx_set_baud(). This eliminates a potential useless read + write cycle each time the baud rate is reconfigured. Fixes: 43c51bb ("sc16is7xx: make sure device is in suspend once probed") Cc: stable <[email protected]> Signed-off-by: Hugo Villeneuve <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 7cbf5ed commit 5036d26

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

drivers/tty/serial/sc16is7xx.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -585,13 +585,6 @@ static int sc16is7xx_set_baud(struct uart_port *port, int baud)
585585
div /= prescaler;
586586
}
587587

588-
/* Enable enhanced features */
589-
sc16is7xx_efr_lock(port);
590-
sc16is7xx_port_update(port, SC16IS7XX_EFR_REG,
591-
SC16IS7XX_EFR_ENABLE_BIT,
592-
SC16IS7XX_EFR_ENABLE_BIT);
593-
sc16is7xx_efr_unlock(port);
594-
595588
/* If bit MCR_CLKSEL is set, the divide by 4 prescaler is activated. */
596589
sc16is7xx_port_update(port, SC16IS7XX_MCR_REG,
597590
SC16IS7XX_MCR_CLKSEL_BIT,

0 commit comments

Comments
 (0)