Skip to content

Commit 4a9d494

Browse files
Mohsin Bashirkuba-moo
authored andcommitted
selftests: drv: net: add version indicator
Currently, the test result does not differentiate between the cases when either one of the address families are configured or if both the address families are configured. Ideally, the result should report if a particular case was skipped. ./drivers/net/ping.py TAP version 13 1..7 ok 1 ping.test_default_v4 # SKIP Test requires IPv4 connectivity ok 2 ping.test_default_v6 ok 3 ping.test_xdp_generic_sb ok 4 ping.test_xdp_generic_mb ok 5 ping.test_xdp_native_sb ok 6 ping.test_xdp_native_mb ok 7 ping.test_xdp_offload # SKIP device does not support offloaded XDP Totals: pass:5 fail:0 xfail:0 xpass:0 skip:2 error:0 Fixes: 75cc19c ("selftests: drv-net: add xdp cases for ping.py") Signed-off-by: Mohsin Bashir <[email protected]> Reviewed-by: David Wei <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 8bb7d8e commit 4a9d494

File tree

1 file changed

+14
-3
lines changed
  • tools/testing/selftests/drivers/net

1 file changed

+14
-3
lines changed

tools/testing/selftests/drivers/net/ping.py

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,13 +136,23 @@ def set_interface_init(cfg) -> None:
136136
cmd(f"ip link set dev {cfg.ifname} xdpoffload off", shell=True)
137137
cmd(f"ip link set dev {cfg.remote_ifname} mtu 1500", shell=True, host=cfg.remote)
138138

139-
def test_default(cfg, netnl) -> None:
139+
def test_default_v4(cfg, netnl) -> None:
140+
cfg.require_ipver("4")
141+
140142
_set_offload_checksum(cfg, netnl, "off")
141143
_test_v4(cfg)
142-
_test_v6(cfg)
143144
_test_tcp(cfg)
144145
_set_offload_checksum(cfg, netnl, "on")
145146
_test_v4(cfg)
147+
_test_tcp(cfg)
148+
149+
def test_default_v6(cfg, netnl) -> None:
150+
cfg.require_ipver("6")
151+
152+
_set_offload_checksum(cfg, netnl, "off")
153+
_test_v6(cfg)
154+
_test_tcp(cfg)
155+
_set_offload_checksum(cfg, netnl, "on")
146156
_test_v6(cfg)
147157
_test_tcp(cfg)
148158

@@ -200,7 +210,8 @@ def main() -> None:
200210
with NetDrvEpEnv(__file__) as cfg:
201211
get_interface_info(cfg)
202212
set_interface_init(cfg)
203-
ksft_run([test_default,
213+
ksft_run([test_default_v4,
214+
test_default_v6,
204215
test_xdp_generic_sb,
205216
test_xdp_generic_mb,
206217
test_xdp_native_sb,

0 commit comments

Comments
 (0)