Skip to content

Commit 46d913d

Browse files
plinga1kuba-moo
authored andcommitted
idpf: cancel mailbox work in error path
In idpf_vc_core_init, the mailbox work is queued on a mailbox workqueue but it is not cancelled on error. This results in a call trace when idpf_mbx_task tries to access the freed mailbox queue pointer. Fix it by cancelling the mailbox work in the error path. Fixes: 4930fbf ("idpf: add core init and interrupt request") Reviewed-by: Wojciech Drewek <[email protected]> Signed-off-by: Pavan Kumar Linga <[email protected]> Tested-by: Krishneil Singh <[email protected]> Signed-off-by: Jacob Keller <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent d38b4d0 commit 46d913d

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/net/ethernet/intel/idpf/idpf_virtchnl.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3146,6 +3146,7 @@ int idpf_vc_core_init(struct idpf_adapter *adapter)
31463146

31473147
err_intr_req:
31483148
cancel_delayed_work_sync(&adapter->serv_task);
3149+
cancel_delayed_work_sync(&adapter->mbx_task);
31493150
idpf_vport_params_buf_rel(adapter);
31503151
err_netdev_alloc:
31513152
kfree(adapter->vports);

0 commit comments

Comments
 (0)