Skip to content

Commit 41b3b8d

Browse files
avaginKAGA-KOKO
authored andcommitted
alarmtimer: Rename gettime() callback to get_ktime()
The upcoming support for time namespaces requires to have access to: - The time in a tasks time namespace for sys_clock_gettime() - The time in the root name space for common_timer_get() struct alarm_base needs to follow the same naming convention, so rename .gettime() callback into get_ktime() as a preparation for introducing get_timespec(). Suggested-by: Thomas Gleixner <[email protected]> Co-developed-by: Dmitry Safonov <[email protected]> Signed-off-by: Andrei Vagin <[email protected]> Signed-off-by: Dmitry Safonov <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent eaf8019 commit 41b3b8d

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

kernel/time/alarmtimer.c

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,13 @@
3636
* struct alarm_base - Alarm timer bases
3737
* @lock: Lock for syncrhonized access to the base
3838
* @timerqueue: Timerqueue head managing the list of events
39-
* @gettime: Function to read the time correlating to the base
39+
* @get_ktime: Function to read the time correlating to the base
4040
* @base_clockid: clockid for the base
4141
*/
4242
static struct alarm_base {
4343
spinlock_t lock;
4444
struct timerqueue_head timerqueue;
45-
ktime_t (*gettime)(void);
45+
ktime_t (*get_ktime)(void);
4646
clockid_t base_clockid;
4747
} alarm_bases[ALARM_NUMTYPE];
4848

@@ -207,7 +207,7 @@ static enum hrtimer_restart alarmtimer_fired(struct hrtimer *timer)
207207
spin_unlock_irqrestore(&base->lock, flags);
208208

209209
if (alarm->function)
210-
restart = alarm->function(alarm, base->gettime());
210+
restart = alarm->function(alarm, base->get_ktime());
211211

212212
spin_lock_irqsave(&base->lock, flags);
213213
if (restart != ALARMTIMER_NORESTART) {
@@ -217,15 +217,15 @@ static enum hrtimer_restart alarmtimer_fired(struct hrtimer *timer)
217217
}
218218
spin_unlock_irqrestore(&base->lock, flags);
219219

220-
trace_alarmtimer_fired(alarm, base->gettime());
220+
trace_alarmtimer_fired(alarm, base->get_ktime());
221221
return ret;
222222

223223
}
224224

225225
ktime_t alarm_expires_remaining(const struct alarm *alarm)
226226
{
227227
struct alarm_base *base = &alarm_bases[alarm->type];
228-
return ktime_sub(alarm->node.expires, base->gettime());
228+
return ktime_sub(alarm->node.expires, base->get_ktime());
229229
}
230230
EXPORT_SYMBOL_GPL(alarm_expires_remaining);
231231

@@ -270,7 +270,7 @@ static int alarmtimer_suspend(struct device *dev)
270270
spin_unlock_irqrestore(&base->lock, flags);
271271
if (!next)
272272
continue;
273-
delta = ktime_sub(next->expires, base->gettime());
273+
delta = ktime_sub(next->expires, base->get_ktime());
274274
if (!min || (delta < min)) {
275275
expires = next->expires;
276276
min = delta;
@@ -364,7 +364,7 @@ void alarm_start(struct alarm *alarm, ktime_t start)
364364
hrtimer_start(&alarm->timer, alarm->node.expires, HRTIMER_MODE_ABS);
365365
spin_unlock_irqrestore(&base->lock, flags);
366366

367-
trace_alarmtimer_start(alarm, base->gettime());
367+
trace_alarmtimer_start(alarm, base->get_ktime());
368368
}
369369
EXPORT_SYMBOL_GPL(alarm_start);
370370

@@ -377,7 +377,7 @@ void alarm_start_relative(struct alarm *alarm, ktime_t start)
377377
{
378378
struct alarm_base *base = &alarm_bases[alarm->type];
379379

380-
start = ktime_add_safe(start, base->gettime());
380+
start = ktime_add_safe(start, base->get_ktime());
381381
alarm_start(alarm, start);
382382
}
383383
EXPORT_SYMBOL_GPL(alarm_start_relative);
@@ -414,7 +414,7 @@ int alarm_try_to_cancel(struct alarm *alarm)
414414
alarmtimer_dequeue(base, alarm);
415415
spin_unlock_irqrestore(&base->lock, flags);
416416

417-
trace_alarmtimer_cancel(alarm, base->gettime());
417+
trace_alarmtimer_cancel(alarm, base->get_ktime());
418418
return ret;
419419
}
420420
EXPORT_SYMBOL_GPL(alarm_try_to_cancel);
@@ -474,7 +474,7 @@ u64 alarm_forward_now(struct alarm *alarm, ktime_t interval)
474474
{
475475
struct alarm_base *base = &alarm_bases[alarm->type];
476476

477-
return alarm_forward(alarm, base->gettime(), interval);
477+
return alarm_forward(alarm, base->get_ktime(), interval);
478478
}
479479
EXPORT_SYMBOL_GPL(alarm_forward_now);
480480

@@ -500,7 +500,7 @@ static void alarmtimer_freezerset(ktime_t absexp, enum alarmtimer_type type)
500500
return;
501501
}
502502

503-
delta = ktime_sub(absexp, base->gettime());
503+
delta = ktime_sub(absexp, base->get_ktime());
504504

505505
spin_lock_irqsave(&freezer_delta_lock, flags);
506506
if (!freezer_delta || (delta < freezer_delta)) {
@@ -632,7 +632,7 @@ static void alarm_timer_arm(struct k_itimer *timr, ktime_t expires,
632632
struct alarm_base *base = &alarm_bases[alarm->type];
633633

634634
if (!absolute)
635-
expires = ktime_add_safe(expires, base->gettime());
635+
expires = ktime_add_safe(expires, base->get_ktime());
636636
if (sigev_none)
637637
alarm->node.expires = expires;
638638
else
@@ -670,7 +670,7 @@ static int alarm_clock_get_timespec(clockid_t which_clock, struct timespec64 *tp
670670
if (!alarmtimer_get_rtcdev())
671671
return -EINVAL;
672672

673-
*tp = ktime_to_timespec64(base->gettime());
673+
*tp = ktime_to_timespec64(base->get_ktime());
674674
return 0;
675675
}
676676

@@ -747,7 +747,7 @@ static int alarmtimer_do_nsleep(struct alarm *alarm, ktime_t absexp,
747747
struct timespec64 rmt;
748748
ktime_t rem;
749749

750-
rem = ktime_sub(absexp, alarm_bases[type].gettime());
750+
rem = ktime_sub(absexp, alarm_bases[type].get_ktime());
751751

752752
if (rem <= 0)
753753
return 0;
@@ -816,7 +816,7 @@ static int alarm_timer_nsleep(const clockid_t which_clock, int flags,
816816
exp = timespec64_to_ktime(*tsreq);
817817
/* Convert (if necessary) to absolute time */
818818
if (flags != TIMER_ABSTIME) {
819-
ktime_t now = alarm_bases[type].gettime();
819+
ktime_t now = alarm_bases[type].get_ktime();
820820

821821
exp = ktime_add_safe(now, exp);
822822
}
@@ -882,9 +882,9 @@ static int __init alarmtimer_init(void)
882882

883883
/* Initialize alarm bases */
884884
alarm_bases[ALARM_REALTIME].base_clockid = CLOCK_REALTIME;
885-
alarm_bases[ALARM_REALTIME].gettime = &ktime_get_real;
885+
alarm_bases[ALARM_REALTIME].get_ktime = &ktime_get_real;
886886
alarm_bases[ALARM_BOOTTIME].base_clockid = CLOCK_BOOTTIME;
887-
alarm_bases[ALARM_BOOTTIME].gettime = &ktime_get_boottime;
887+
alarm_bases[ALARM_BOOTTIME].get_ktime = &ktime_get_boottime;
888888
for (i = 0; i < ALARM_NUMTYPE; i++) {
889889
timerqueue_init_head(&alarm_bases[i].timerqueue);
890890
spin_lock_init(&alarm_bases[i].lock);

0 commit comments

Comments
 (0)